Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove get-codeowners.ps1 from docs automation #7040

Merged
merged 5 commits into from
Oct 2, 2023

Conversation

danieljurek
Copy link
Member

@danieljurek danieljurek commented Sep 29, 2023

Fixes #6461

This also requires changes to docs repos which remove the author and ms.author values written into individual markdown files and configures docfx.json to set default author and ms.author values for those files.

Required changes after this merges:

  1. Remove credential params in docindex.yml for each language
  2. Merge changes to docfx.json and removal of author metadata for each docs repo

Examples:

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@danieljurek danieljurek marked this pull request as ready for review October 2, 2023 18:58
Copy link
Member

@JimSuplizio JimSuplizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Daniel,
As per our discussion over teams. I'm good with these changes. For anyone else, there was one requested change which was done with the 5th commit that fixed up the notification-configuration solution which, for some reason, opted to pull in the entire CodeownersParser solution instead of just the library's project like the other consumers do.

azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Oct 2, 2023
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#7040 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Daniel Jurek <djurek@microsoft.com>
@danieljurek danieljurek merged commit 95ba08b into main Oct 2, 2023
21 checks passed
@danieljurek danieljurek deleted the djurek/docs-metadata-fixes branch October 2, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs automation] Replace GitHub owner resolution with a DL
4 participants