Use CodeownersFile.UseRegexMatcherDefault everywhere where applicable + remove obsolete tests
#5437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konrad-jamrozik
added
the
Central-EngSys
konrad-jamrozik
changed the title
CodeownersFile.UseRegexMatcherDefault everywhere where applicableCodeownersFile.UseRegexMatcherDefault everywhere where applicable
konrad-jamrozik
changed the title
CodeownersFile.UseRegexMatcherDefault everywhere where applicableCodeownersFile.UseRegexMatcherDefault everywhere where applicable + remove obsolete tests
|
The following pipelines have been queued for testing: |
This was referenced Feb 14, 2023
benbp
approved these changes
Feb 14, 2023
azure-sdk
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Feb 14, 2023
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#5437 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Konrad Jamrozik <kojamroz@microsoft.com>
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
ghost
pushed a commit
that referenced
this pull request
Feb 16, 2023
…ers` executable + add some tests; make assorted refactorings (#5103) This PR is part of work required in preparation to merge: - #5088 Specifically, to enable review of ownership changes due to upcoming wildcards support, as explained in: - #5088 (comment) As such, this PR contributes to: - #2770 This PR is a prerequisite for following PRs: - #5431 ### Merging prerequisite This PR can be merged only after the following PRs are merged and relevant NuGet package published - #5437 - #5104 This is because this PR depends on that NuGet package.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update 2/16/2023: Follow-up PR:
NotificationConfigurationpackage to20230214.1to enableCODEOWNERSregex matcher to default totrue#5452This is a follow-up PR to:
azure-sdk-for-netrepo #5241That PR was supposed to enable the regex-based matcher everywhere, but didn't. This PR fixes that.
This PR also:
ProgramSimplePathTeststest class; it is superseded byProgramGlobPathTests, which is renamed in:CODEOWNERSmatcher #5431get-codeowners.ps1This PR is a prerequisite for following PRs:
get-codeowners.ps1to work with the updatedRetrieveCodeOwnersexecutable + add some tests; make assorted refactorings #5103CODEOWNERSmatcher #5431