Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip unnecessary and misleading role assignment warnings in local test resource deployment #2075

Merged
1 commit merged into from
Oct 7, 2021

Conversation

benbp
Copy link
Member

@benbp benbp commented Oct 5, 2021

The "cannot assign owner" warning message will print on repeated local runs for the script when people don't have owner, and is somewhat of a red herring (as explained in the code comments). I don't think it's actually necessary to warn here since we already skip this section on first run of the script.

@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Oct 5, 2021
@benbp benbp self-assigned this Oct 5, 2021
@benbp benbp requested a review from annelo-msft October 5, 2021 21:21
Copy link
Member

@annelo-msft annelo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benbp benbp requested a review from jsquire October 5, 2021 21:29
@benbp benbp force-pushed the benbp/tools-error-msg branch from 7b2639f to 28fba9b Compare October 5, 2021 21:41
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@ghost
Copy link

ghost commented Oct 7, 2021

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@benbp
Copy link
Member Author

benbp commented Oct 7, 2021

/check-enforcer evaluate

@ghost ghost merged commit 04becd1 into Azure:main Oct 7, 2021
@benbp benbp deleted the benbp/tools-error-msg branch October 7, 2021 17:19
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants