Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test-Proxy] eng/common templates #1909

Merged
19 commits merged into from
Aug 17, 2021
Merged

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Aug 13, 2021

Changes in this PR:

  • Add test proxy tool and docker invocations to the eng/common yaml.
  • Update eng/common with the SSL-related items so they can be trusted by language-specific tooling
  • Update documentation and build to reflect new certificate files location.

Ok. @weshaggard I have added a prepare.ps1 to the test-proxy/docker folder. Updated the documentation that refers to the certificate by name/location. Updated the docker build to be able to run the prepare.ps1 script.

Successful Test invocation using these location changes in sdk-for-python
Successful Test container publish

@scbedd scbedd requested review from mikeharder and a team as code owners August 13, 2021 22:58
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@weshaggard
Copy link
Member

I'm super conflicted about where to put dotnet-devcert.pfx/crt.

Lets start with only one under eng/common and I'd suggest having a script that can be used to setup the certificate even if it is a separate command from the docker run. We can then wait for feedback about what people end up doing and make adjustments as necessary. My hope is that most folks doing this locally won't need to care about the certificate at all.

@benbp
Copy link
Member

benbp commented Aug 16, 2021

@scbedd one possible solution: you could publish another docker image from tools that just contains the dev cert and the desired path, and then use multiple FROM directives to overlay your "test proxy assets" filesystem into the image build. That way you wouldn't need any external directory context, and could manage updates to the dev cert easily. You could then remove all these lines and make the dockerfile a little simpler.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@scbedd
Copy link
Member Author

scbedd commented Aug 16, 2021

@benbp I am going to head this direction. First thing I'm going to do is force the build of the current dockerfile images from the root of the repo, thereby allowing access to the common assets. After that, I'll add two docker images that abstract the build of those assets. I would do it now, but I need to get this merged quickly.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@scbedd scbedd self-assigned this Aug 17, 2021
@scbedd scbedd added the Central-EngSys This issue is owned by the Engineering System team. label Aug 17, 2021
@ghost
Copy link

ghost commented Aug 17, 2021

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@scbedd scbedd removed the auto-merge label Aug 17, 2021
@ghost ghost merged commit c0d142a into Azure:main Aug 17, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants