Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI trigger back to pipeline generator #1410

Merged
merged 2 commits into from
Mar 9, 2021

Conversation

mitchdenny
Copy link
Contributor

Now that we have the majority of Azure SDK pipelines running on the 1ES pools and we have better capacity to scale, this PR adds back the CI triggers so that once a merge is completed that we get a CI run. This will help narrow down build failures in pipelines that occur post merge whereas at the moment it can sometimes take some digging to figure out what particular change introduced a problem.

@mitchdenny mitchdenny self-assigned this Feb 16, 2021
@mitchdenny mitchdenny added Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system. labels Feb 16, 2021
@weshaggard
Copy link
Member

I think this might still be a little premature until we gather more data about our current usages I'd like to avoid enabling these CI triggers yet.

@mitchdenny
Copy link
Contributor Author

What is the primary concern? Lack of ability to scale, cost, both, or something else?

@weshaggard
Copy link
Member

The primary concern is cost vs value. I'd like to make sure we get some good data, both cost as well as usage data over a few months with our new 1ES agents before we turn this on. Once we have this data we will have a clearer picture of how much these new pools are costing for the existing jobs and decide if we think it is worth the cost of enabling the CI triggers.

@mitchdenny
Copy link
Contributor Author

I think the spend is now pretty well understood (we have a baseline from January, and February is looking to be on-track. There could be a bit of seasonality in there but I wouldn't expect a huge hike unless we change VM sizes/locations. I'll follow-up offline with the data that we already have. Really running the CI jobs post merge just amounts to everyone submitting one more commit to an already open PR.

@mitchdenny mitchdenny merged commit 1a5b477 into Azure:master Mar 9, 2021
@mitchdenny mitchdenny deleted the add-ci-trigger-back branch March 9, 2021 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants