Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conditions to test pipeline generation. #1133

Merged

Conversation

mitchdenny
Copy link
Contributor

Replicating behavior from our main pipeline generator which will opt out of generating pipelines if there are no options specified.

@mitchdenny mitchdenny requested a review from a team as a code owner October 22, 2020 09:24
@mitchdenny mitchdenny added Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system. labels Oct 22, 2020
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@ghost
Copy link

ghost commented Oct 22, 2020

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 01d69ff into Azure:master Oct 22, 2020
@@ -71,6 +71,7 @@ steps:
--debug
${{parameters.TestsConventionOptions}}
displayName: Create Live Test pipelines for public repository
condition: ne(variables['TestsConventionOptions'],'')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include succeeded() to these conditions.

benbp pushed a commit that referenced this pull request Dec 1, 2020
Replicating behavior from our main pipeline generator which will opt out of generating pipelines if there are no options specified.
sima-zhu pushed a commit to sima-zhu/azure-sdk-tools that referenced this pull request Dec 3, 2020
* Turn warnings as errors  for doxygen and add missing docs.

* Try to log warnings to a file.

* Update script and add comment to internal fields in json.

* Update the storage docs.

* Change the script to pwsh and write an error message.

* Fix remaining warnings.

* Only fail if the file is not empty and clean up after and fix typo in a
comment.

* Fix typo in commment.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants