[Event Hubs] Add a 20% random jitter to the EP load balancing interval. #9713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunhaoling
reviewed
Feb 4, 2020
| @@ -310,6 +311,8 @@ def _create_tasks_for_claimed_ownership( | |||
| if not self._running: | |||
| self._running = True | |||
| while self._running: | |||
| random_jitter = self._load_balancing_interval * random.random() * 0.2 | |||
There was a problem hiding this comment.
It seems Java gives a fixed base jitter (2 seconds) time and use n * BASE (n in [0,1]) as the final jitter.
https://github.com/Azure/azure-sdk-for-java/blob/master/sdk/eventhubs/azure-messaging-eventhubs/src/main/java/com/azure/messaging/eventhubs/EventProcessorClient.java#L43
So it's
load_balancing_interval * (1 + ratio) VS load_balancing_interval + ratio * base_jitter
There was a problem hiding this comment.
A fixed base jitter 2 seconds would be too large if the load balancing interval is small. A propotional value is better I think. Java fixes the interval at 10 so the base jitter is 2, not a proportional value.
yunhaoling
approved these changes
Feb 4, 2020
|
/azp run python - eventhubs - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
annatisch
approved these changes
Feb 18, 2020
openapi-sdkautomation bot
referenced
this pull request
in AzureSDKAutomation/azure-sdk-for-python
Jun 4, 2020
update (#9713) Co-authored-by: Yingying Song <yison@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #9575