Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Certs Sync #6353

Closed
wants to merge 70 commits into from
Closed

Certs Sync #6353

wants to merge 70 commits into from

Conversation

iscai-msft
Copy link
Contributor

No description provided.

@adxsdk6
Copy link

adxsdk6 commented Jul 15, 2019

Can one of the admins verify this patch?

@kurtzeborn kurtzeborn added KeyVault Mgmt This issue is related to a management-plane library. labels Jul 16, 2019
chlowell
chlowell reviewed Jul 22, 2019
View reviewed changes
Copy link
Member

@chlowell chlowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please copy the _shared package from azure-keyvault-keys and use it here? Looks like this needs a merge of or rebase onto master as well.

sdk/keyvault/azure-keyvault-certificates/README.md Outdated Show resolved Hide resolved
sdk/keyvault/azure-keyvault-certificates/Pipfile Outdated Show resolved Hide resolved
sdk/keyvault/azure-keyvault-certificates/tests/certificates_vault_client.py Outdated Show resolved Hide resolved
@chlowell chlowell added Client This issue points to a problem in the data-plane of the library. and removed Mgmt This issue is related to a management-plane library. labels Aug 7, 2019
@chlowell chlowell mentioned this pull request Aug 7, 2019
Closed
@iscai-msft iscai-msft closed this Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chlowell chlowell chlowell left review comments

@schaabs schaabs Awaiting requested review from schaabs

@zikalino zikalino Awaiting requested review from zikalino

Assignees

@iscai-msft iscai-msft

Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iscai-msft @adxsdk6 @chlowell @kurtzeborn @samvaity