Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate EventGrid data plane SDK to include event Schemas for new … #5346

Merged
merged 7 commits into from
May 21, 2019

Conversation

lmazuel
Copy link
Member

@lmazuel lmazuel commented May 20, 2019

…event types from IotHub, Media Services, Container Registry, Maps, and AppConfiguration services. (#5232)

Merge into a local branch for CI

…event types from IotHub, Media Services, Container Registry, Maps, and AppConfiguration services. (#5232)
@lmazuel lmazuel requested a review from kalyanaj May 20, 2019 19:20
@AutorestCI
Copy link
Contributor

AutorestCI commented May 20, 2019

(message created by the CI based on PR content)

Installation instruction

Package azure-eventgrid

You can install the package azure-eventgrid of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_eventgrid/data-plane#egg=azure-eventgrid&subdirectory=azure-eventgrid"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_eventgrid/data-plane#egg=azure-eventgrid&subdirectory=azure-eventgrid"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_eventgrid/data-plane
  • pip install -e ./azure-eventgrid

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_eventgrid/data-plane
  • pip wheel --no-deps ./azure-eventgrid

Direct download

Your files can be directly downloaded here:

@codecov-io
Copy link

codecov-io commented May 20, 2019

Codecov Report

Merging #5346 into master will increase coverage by 0.06%.
The diff coverage is 55.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5346      +/-   ##
==========================================
+ Coverage   48.33%   48.39%   +0.06%     
==========================================
  Files        6557     6622      +65     
  Lines      188652   189526     +874     
==========================================
+ Hits        91178    91723     +545     
- Misses      97474    97803     +329
Impacted Files Coverage Δ
.../models/iot_hub_device_connected_event_data_py3.py 80% <ø> (ø)
...azure/eventgrid/models/device_twin_metadata_py3.py 66.66% <ø> (ø)
...rid/models/container_registry_event_request_py3.py 40% <ø> (ø)
...ls/device_connection_state_event_properties_py3.py 44.44% <ø> (ø)
...grid/models/storage_blob_created_event_data_py3.py 26.66% <ø> (ø)
...ventgrid/models/device_twin_info_properties_py3.py 57.14% <ø> (ø)
...ventgrid/models/resource_write_failure_data_py3.py 25% <ø> (ø)
...id/models/iot_hub_device_deleted_event_data_py3.py 80% <ø> (ø)
...rid/models/device_twin_info_x509_thumbprint_py3.py 57.14% <ø> (ø)
...ventgrid/models/resource_action_cancel_data_py3.py 25% <ø> (ø)
... and 142 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0232dae...921fad1. Read the comment docs.

Copy link
Contributor

@kalyanaj kalyanaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Laurent for the changes, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants