Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx comment for lab services client enums #4366

Merged
merged 1 commit into from
Feb 15, 2019
Merged

FIx comment for lab services client enums #4366

merged 1 commit into from
Feb 15, 2019

Conversation

ianhays
Copy link

@ianhays ianhays commented Feb 14, 2019

@ianhays ianhays requested a review from lmazuel as a code owner February 14, 2019 22:11
@adxsdk6
Copy link

adxsdk6 commented Feb 14, 2019

Can one of the admins verify this patch?

1 similar comment
@adxsdk6
Copy link

adxsdk6 commented Feb 14, 2019

Can one of the admins verify this patch?

@glibnub
Copy link

glibnub commented Feb 14, 2019

LGTM from a docs perspective.

@ianhays
Copy link
Author

ianhays commented Feb 14, 2019

Thanks @dendeli-msft, feel free to merge whenever.

@codecov-io
Copy link

Codecov Report

Merging #4366 into master will decrease coverage by 3.88%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4366      +/-   ##
==========================================
- Coverage   53.53%   49.64%   -3.89%     
==========================================
  Files       10458     6273    -4185     
  Lines      218693   175237   -43456     
==========================================
- Hits       117072    86998   -30074     
+ Misses     101621    88239   -13382
Impacted Files Coverage Δ
...afactory/azure/mgmt/datafactory/models/__init__.py 50.67% <0%> (-49.33%) ⬇️
...ights/azure/applicationinsights/models/__init__.py 51% <0%> (-49%) ⬇️
...e/cognitiveservices/vision/face/models/__init__.py 51.25% <0%> (-48.75%) ⬇️
...iveservices/search/entitysearch/models/__init__.py 51.25% <0%> (-48.75%) ⬇️
azure-eventgrid/azure/eventgrid/models/__init__.py 51.25% <0%> (-48.75%) ⬇️
...ration/azure/mgmt/datamigration/models/__init__.py 51.27% <0%> (-48.73%) ⬇️
...ure/mgmt/recoveryservicesbackup/models/__init__.py 51.46% <0%> (-48.54%) ⬇️
...ce/azure/mgmt/containerinstance/models/__init__.py 51.8% <0%> (-48.2%) ⬇️
...tiveservices/search/videosearch/models/__init__.py 52.08% <0%> (-47.92%) ⬇️
.../azure/mgmt/compute/v2018_10_01/models/__init__.py 52.46% <0%> (-47.54%) ⬇️
... and 4267 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5b7af7...1c1f46c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants