Removed **provisional** from computed_properties #39543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pilchie
approved these changes
Feb 3, 2025
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
yup, added to the 2025-01-24 changelog |
bambriz
reviewed
Feb 10, 2025
bambriz
requested changes
Feb 10, 2025
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
simorenoh
reviewed
Feb 11, 2025
sdk/cosmos/azure-cosmos/test/test_query_computed_properties_async.py
Outdated
Show resolved
Hide resolved
simorenoh
reviewed
Feb 11, 2025
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kushagraThapar
requested changes
Feb 12, 2025
|
@andrewmathew1 - since all of the tests have already passed, so you don't need to run the CI again, and get your PR in once you have made the above changes, thanks! |
kushagraThapar
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed provisional from computed_properties in database.py and _database.py.
Added computed_properties to function definition in database.py and _database.py.
Annotated computed_properties tests.
Added in feature of replacing computed_properties when using the replace_container method.
Added tests for replacing computed_properties.
Removed duplicate tests for computed_properties in tests_query.py and test_query_async.py.
Renamed test_query_computed_properties to test_computed_properties to reflect new tests.
Recorded changes in CHANGELOG.md.