-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace compile-time validateFormatting
parameter
#38212
Conversation
…validateFormatting enabled, and set that to false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this going to cause CI failures if an sdk currently has black=True but ValidateFormatting False?
Yep. I'm finding the # of packages that fit in that gap (that aren't mgmt). We don't run If not...we'll see 😆 |
We have one of two avenues:
OR
|
I think right now black is an opt-in so I would vote for 1 to remain consistent |
Agreed, I'll make that change in this PR after making the other adjustments for opt in. |
…the parameter validateFormatting
API change check API changes are not detected in this pull request. |
/check-enforcer override Single failure to download an environment seed. |
Resolves #35153
validateFormatting
parameterblack
is opt-out by default, but individual packages can opt in withblack = true
in theirpyproject.toml
ci.yml
to remove validateFormatting and individually re-enabledblack
on those packages that were running it prior to this PR.This change is necessary because of the fact that
python - pullrequest
doesn't have access to the parameter that you have set for yourci.yml
. We need to emplace it some place else that's universal.I'm taking a look now because @LibbaLawrence ran into exactly this issue with
azure-eventhub
running onpython - pullrequest
.This PR moves these settings from the
validateFormatting
template parameter to a per-packagepyproject.toml
.TODO:
validate_formatting.py
into being called fromtox
instead ofvalidate_formatting
calling `tox.black
calling script withis_check_enabled
.