-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SchemaRegistry] handle unknown content types #37166
Merged
swathipil
merged 7 commits into
Azure:main
from
swathipil:swathipil/sr/return-unknown-contenttype-string
Sep 6, 2024
Merged
[SchemaRegistry] handle unknown content types #37166
swathipil
merged 7 commits into
Azure:main
from
swathipil:swathipil/sr/return-unknown-contenttype-string
Sep 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API change check API changes are not detected in this pull request. |
l0lawrence
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
kashifkhan
reviewed
Sep 6, 2024
kashifkhan
reviewed
Sep 6, 2024
kashifkhan
approved these changes
Sep 6, 2024
l0lawrence
pushed a commit
to l0lawrence/azure-sdk-for-python
that referenced
this pull request
Feb 19, 2025
* [SchemaRegistry] handle unknown content types * remove extra space in Accept headers * fix license in tests * fix spacing in accept header async * add tests with mocked unknown content type * mypy/lint * cspell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion with architects, return the content type string in SchemaProperties.format if unknown. Make sure the behavior is well-documented; added a warning to the get_schema method for this behavior.
TODO: