Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SchemaRegistry] handle unknown content types #37166

Merged

Conversation

swathipil
Copy link
Member

@swathipil swathipil commented Aug 30, 2024

As per discussion with architects, return the content type string in SchemaProperties.format if unknown. Make sure the behavior is well-documented; added a warning to the get_schema method for this behavior.

TODO:

  • add a test with MockResponse for an unknown content type.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@swathipil swathipil marked this pull request as ready for review September 5, 2024 00:20
Copy link
Member

@l0lawrence l0lawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@swathipil swathipil merged commit 6db6bd9 into Azure:main Sep 6, 2024
19 checks passed
@swathipil swathipil deleted the swathipil/sr/return-unknown-contenttype-string branch September 6, 2024 22:17
l0lawrence pushed a commit to l0lawrence/azure-sdk-for-python that referenced this pull request Feb 19, 2025
* [SchemaRegistry] handle unknown content types

* remove extra space in Accept headers

* fix license in tests

* fix spacing in accept header async

* add tests with mocked unknown content type

* mypy/lint

* cspell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants