Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discovery Async #37061

Merged
merged 15 commits into from
Sep 6, 2024
Merged

Discovery Async #37061

merged 15 commits into from
Sep 6, 2024

Conversation

mrm9084
Copy link
Member

@mrm9084 mrm9084 commented Aug 27, 2024

Description

Makes the same change as sync Discover, but discovery is done in a thread.

  • Fixes a bug where some Feature Flag requests didn't have headers.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-appconfiguration-provider

@mrm9084 mrm9084 requested a review from rossgrambo September 5, 2024 21:22
@mrm9084 mrm9084 enabled auto-merge (squash) September 6, 2024 18:40
@mrm9084 mrm9084 merged commit f17312e into Azure:main Sep 6, 2024
19 checks passed
@mrm9084 mrm9084 deleted the DiscoveryAsync branch September 6, 2024 19:41
l0lawrence pushed a commit to l0lawrence/azure-sdk-for-python that referenced this pull request Feb 19, 2025
@mrm9084 @l0lawrence
Discovery Async (Azure#37061)
f654c52 
* fixing header bug

* Async Discover + Failover

* Fixing Test, mypy, and pylint issues

* Fix test async issue

* review comments

* more spelling fixes

* Trying to fix async test issue

* try to fix async issue

* Update test_configuration_async_client_manager.py

* async discovery

* Rename, add sync lock, add type check

* removing unneeded lock.

* client base

* Added missing lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertofori albertofori albertofori left review comments

@avanigupta avanigupta avanigupta approved these changes

@rossgrambo rossgrambo Awaiting requested review from rossgrambo rossgrambo is a code owner

Assignees
No one assigned
Labels
App Configuration Provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrm9084 @azure-sdk @avanigupta @albertofori