Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Component Governance to reduce scanned directories for Build Extended template #36994

Merged
merged 6 commits into from
Sep 9, 2024

Conversation

pauld-msft
Copy link
Member

@pauld-msft pauld-msft commented Aug 22, 2024

Description

This pull request reduces the scope of the Build Extended run of Component Governance to the relevant directory that is being built. Previously, Component Governance was running on the entire repository, causing long task times.

Old example: https://dev.azure.com/azure-sdk/public/_build/results?buildId=4077914&view=logs&j=4259cd7e-6a4b-5ca5-581a-0ae020cd9d20&t=3a70d42c-4cbe-5d44-55a0-70dc5de3988f
New example: https://dev.azure.com/azure-sdk/public/_build/results?buildId=4081557&view=logs&j=4259cd7e-6a4b-5ca5-581a-0ae020cd9d20&t=3a70d42c-4cbe-5d44-55a0-70dc5de3988f

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@pauld-msft pauld-msft marked this pull request as ready for review August 26, 2024 14:24
@pauld-msft pauld-msft changed the title [draft] update build extended pipeline to include cd task Update Component Governance to reduce scanned directories for Build Extended template Aug 26, 2024
@scbedd
Copy link
Member

scbedd commented Sep 9, 2024

Taking back what I originally said in mail...on re-read of the yml I realize that CG doesn't run on public builds, which is the only place the logic I was referencing exists.

I will approve and merge this PR to see what changes.

@scbedd scbedd merged commit 7cd1a97 into Azure:main Sep 9, 2024
19 checks passed
l0lawrence pushed a commit to l0lawrence/azure-sdk-for-python that referenced this pull request Feb 19, 2025
…xtended template (Azure#36994)

* update build_extended job to direct component detection to sdk/<servicedirectory>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants