Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use deprecated TokenCache.find() #36714

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Do not use deprecated TokenCache.find() #36714

merged 1 commit into from
Aug 1, 2024

Conversation

akx
Copy link
Contributor

@akx akx commented Aug 1, 2024

Description

Fixes #36713 by not using the deprecated TokenCache.find() method.

azure-identity already requires msal>=1.29.0, so this should be safe.

There are other uses of _cache.find() around the monorepo, but no other package declares that it depends on msal 1.29.0+, so changing those may not be safe.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@akx
Do not use deprecated TokenCache.find()
6a2e620 
azure-identity already requires msal>=1.29.0, so this should be safe.

Fixes Azure#36713
@akx akx requested review from pvaneck, xiangyan99 and a team as code owners August 1, 2024 12:05
@github-actions github-actions bot added Azure.Identity Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Aug 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024

Thank you for your contribution @akx! We will review the pull request and get back to you soon.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

xiangyan99
xiangyan99 approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@xiangyan99 xiangyan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions. This looks great!

@xiangyan99 xiangyan99 merged commit 5b171c8 into Azure:main Aug 1, 2024
36 checks passed
@akx akx deleted the cache-find branch August 2, 2024 05:25
l0lawrence pushed a commit to l0lawrence/azure-sdk-for-python that referenced this pull request Feb 19, 2025
@akx @l0lawrence
Do not use deprecated TokenCache.find() (Azure#36714)
bff51ba 
azure-identity already requires msal>=1.29.0, so this should be safe.

Fixes Azure#36713
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangyan99 xiangyan99 xiangyan99 approved these changes

@pvaneck pvaneck Awaiting requested review from pvaneck pvaneck is a code owner

@joshfree joshfree Awaiting requested review from joshfree joshfree is a code owner automatically assigned from Azure/azure-sdk-write-identity

@g2vinay g2vinay Awaiting requested review from g2vinay g2vinay is a code owner automatically assigned from Azure/azure-sdk-write-identity

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya KarishmaGhiya is a code owner automatically assigned from Azure/azure-sdk-write-identity

@scottaddie scottaddie Awaiting requested review from scottaddie scottaddie is a code owner automatically assigned from Azure/azure-sdk-write-identity

@chlowell chlowell Awaiting requested review from chlowell chlowell is a code owner automatically assigned from Azure/azure-sdk-write-identity

Assignees
No one assigned
Labels
Azure.Identity Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
Azure Identity SDK Improvements
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

azure.identity.credentials raises DeprecationWarnings in Microsoft MSAL code
3 participants
@akx @azure-sdk @xiangyan99