Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate and implement Face SDK via TypeSpec #35384

Merged
merged 42 commits into from
May 16, 2024
Merged

Generate and implement Face SDK via TypeSpec #35384

merged 42 commits into from
May 16, 2024

Conversation

zihyunting
Copy link
Member

Description

This PR contains:

ToDo:

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@zihyunting zihyunting requested a review from lmazuel as a code owner April 26, 2024 17:02
@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Apr 26, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution @zihyunting! We will review the pull request and get back to you soon.

SDKAuto and others added 5 commits April 30, 2024 04:13
CodeGen from PR 27576 in Azure/azure-rest-api-specs
f0b87e2 
Merge 482ba279cb21fbf7f4e6bbd4ad14b6c14aa979d7 into b8af2fc3af08e42d2df6f48d1c84070ef1f6589b
@zihyunting
Fix SDK error
dae9679
@zihyunting
SDK Customization
2673dbd
@zihyunting
test-resources.json
de6d3d9
@zihyunting
Samples
dfc57f5
@zihyunting zihyunting force-pushed the azure-ai-vision-face-test-cases-and-samples branch 2 times, most recently from d0d8ad2 to 931b3a6 Compare April 30, 2024 14:31
kristapratico
kristapratico reviewed May 1, 2024
View reviewed changes
sdk/face/azure-ai-vision-face/README.md Outdated Show resolved Hide resolved
sdk/face/azure-ai-vision-face/README.md Outdated Show resolved Hide resolved
sdk/face/azure-ai-vision-face/README.md Outdated Show resolved Hide resolved
sdk/face/azure-ai-vision-face/README.md Outdated Show resolved Hide resolved
sdk/face/azure-ai-vision-face/README.md Outdated Show resolved Hide resolved
sdk/face/azure-ai-vision-face/samples/_shared/constants.py Outdated Show resolved Hide resolved
sdk/face/azure-ai-vision-face/samples/async_samples/samples_authentication_async.py Outdated Show resolved Hide resolved
sdk/face/azure-ai-vision-face/samples/async_samples/samples_authentication_async.py Outdated Show resolved Hide resolved
sdk/face/azure-ai-vision-face/samples/async_samples/samples_find_similar_faces_async.py Outdated Show resolved Hide resolved
sdk/face/azure-ai-vision-face/tests/preparers.py Show resolved Hide resolved
@kristapratico
Copy link
Member

/azp run prepare-pipelines

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@zihyunting
Copy link
Member Author

/azp run prepare-pipelines

@azure-pipelines Azure Pipelines
Copy link

Commenter does not have sufficient privileges for PR 35384 in repo Azure/azure-sdk-for-python

@zihyunting zihyunting mentioned this pull request May 3, 2024
Merged
@msyyc
Copy link
Member

msyyc commented May 9, 2024 •
edited
Loading

@zihyunting Please make sure CI passed for all these items:
image
nit: The Details link contain detailed log info and you can fix with those info

@zihyunting zihyunting force-pushed the azure-ai-vision-face-test-cases-and-samples branch from fc30b3c to c422332 Compare May 9, 2024 10:18
@zihyunting zihyunting force-pushed the azure-ai-vision-face-test-cases-and-samples branch from 6dc4672 to 85554ab Compare May 9, 2024 12:39
@zihyunting zihyunting force-pushed the azure-ai-vision-face-test-cases-and-samples branch 2 times, most recently from 4e3b11e to 85554ab Compare May 10, 2024 10:29
msyyc
msyyc approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@msyyc msyyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. It will be better if you could use black to format the code snippet in README.md.

pip install black
black myfile.py -l 120

@kristapratico kristapratico merged commit a87b4c0 into Azure:main May 16, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catalinaperalta catalinaperalta catalinaperalta left review comments

@Han-msft Han-msft Han-msft left review comments

@msyyc msyyc msyyc approved these changes

@kristapratico kristapratico kristapratico approved these changes

@lmazuel lmazuel Awaiting requested review from lmazuel

Assignees
No one assigned
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zihyunting @kristapratico @azure-sdk @msyyc @Han-msft @catalinaperalta