Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with retryable exception in first page of query #35022

Closed
wants to merge 1 commit into from
Closed

Fix bug with retryable exception in first page of query #35022

wants to merge 1 commit into from

Conversation

nicknotfun
Copy link
Contributor

Description

Fixes #35021

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • [?] Pull request includes test coverage for the included changes.

@github-actions github-actions bot added Community Contribution Community members are working on the issue Cosmos customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Mar 31, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution @nicknotfun! We will review the pull request and get back to you soon.

@nicknotfun
Copy link
Contributor Author 

@microsoft-github-policy-service agree company="Microsoft"

@microsoft-github-policy-service agree company="OpenAI"

@bambriz bambriz mentioned this pull request Apr 5, 2024
Merged
6 tasks
@kushagraThapar
Copy link
Member

Closing this PR as the other PR: #35090 has been merged in main which includes changes from this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushagraThapar kushagraThapar Awaiting requested review from kushagraThapar

@simorenoh simorenoh Awaiting requested review from simorenoh

@xinlian12 xinlian12 Awaiting requested review from xinlian12

@annatisch annatisch Awaiting requested review from annatisch annatisch is a code owner

@bambriz bambriz Awaiting requested review from bambriz

Assignees
No one assigned
Labels
Community Contribution Community members are working on the issue Cosmos customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

when retryable error happens, cosmos client returns empty result for pagination query
2 participants
@nicknotfun @kushagraThapar