-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cosmos] changes and sample for vector search control plane update #34882
Conversation
API change check APIView has identified API level changes in this PR and created following API reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me, however, requesting changes on some documentation
/azp run python - cosmos |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run python - cosmos |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run python - cosmos - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
These changes were merged as part of #35468. |
Changes for control-plane vector search bits, adding the vector embedding policy to container creation flow and the vector indexes to the existing indexing policy based on the doc shared and PRs done by the service team.
Samples and tests have been added as well.
Relevant updates just mean our indexing policy now has additional vector indexing fields:
![image](https://private-user-images.githubusercontent.com/30335873/317854456-e32ab3d2-5f36-4be0-ba4f-23b9cb8b9a27.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2ODkzNDUsIm5iZiI6MTczOTY4OTA0NSwicGF0aCI6Ii8zMDMzNTg3My8zMTc4NTQ0NTYtZTMyYWIzZDItNWYzNi00YmUwLWJhNGYtMjNiOWNiOGI5YTI3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDA2NTcyNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWYyYjQwZGJlNjA1YzdjNDA3YzQ0N2VjMTE4ZGQ0ODkxMjBjMjM0ZTZkMDhhNmUzM2I2NDIwMGZmNDhmZjNkODMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.QXC4TBhzUTgFfJWyJhS2NsntNBfWOFRQd6_yTwnDzK4)
And we now have the ability to pass in a new vector embedding policy json that looks like this:
![image](https://private-user-images.githubusercontent.com/30335873/317866398-df95fc50-c711-4e1b-af24-9e2d8ae8fc61.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2ODkzNDUsIm5iZiI6MTczOTY4OTA0NSwicGF0aCI6Ii8zMDMzNTg3My8zMTc4NjYzOTgtZGY5NWZjNTAtYzcxMS00ZTFiLWFmMjQtOWUyZDhhZThmYzYxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDA2NTcyNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQxNjY2ZDdhMzAyNjEwZDE0MjNlZjk1YzQ2MThkODRlMzNlYzY3NDI3YjA4NjVkNTRiZmZmNmY5OTg5ZGQ4YTEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.DWxx8_C7oB6ni5po_hjbxemCCes2yEj_IU8WGKBylAM)
I opted for leaving a raw dictionary/json for the new policy since it aligns with the already existing indexing policy, but if we feel we should change this do let me know.