Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR containerservices/resource-manager] Remove serverAppSecret which is not required for AKS cluster updates #3376

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class ManagedClusterAADProfile(Model):
:type client_app_id: str
:param server_app_id: Required. The server AAD application ID.
:type server_app_id: str
:param server_app_secret: Required. The server AAD application secret.
:param server_app_secret: The server AAD application secret.
:type server_app_secret: str
:param tenant_id: The AAD tenant ID to use for authentication. If not
specified, will use the tenant of the deployment subscription.
Expand All @@ -31,7 +31,6 @@ class ManagedClusterAADProfile(Model):
_validation = {
'client_app_id': {'required': True},
'server_app_id': {'required': True},
'server_app_secret': {'required': True},
}

_attribute_map = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class ManagedClusterAADProfile(Model):
:type client_app_id: str
:param server_app_id: Required. The server AAD application ID.
:type server_app_id: str
:param server_app_secret: Required. The server AAD application secret.
:param server_app_secret: The server AAD application secret.
:type server_app_secret: str
:param tenant_id: The AAD tenant ID to use for authentication. If not
specified, will use the tenant of the deployment subscription.
Expand All @@ -31,7 +31,6 @@ class ManagedClusterAADProfile(Model):
_validation = {
'client_app_id': {'required': True},
'server_app_id': {'required': True},
'server_app_secret': {'required': True},
}

_attribute_map = {
Expand All @@ -41,7 +40,7 @@ class ManagedClusterAADProfile(Model):
'tenant_id': {'key': 'tenantID', 'type': 'str'},
}

def __init__(self, *, client_app_id: str, server_app_id: str, server_app_secret: str, tenant_id: str=None, **kwargs) -> None:
def __init__(self, *, client_app_id: str, server_app_id: str, server_app_secret: str=None, tenant_id: str=None, **kwargs) -> None:
super(ManagedClusterAADProfile, self).__init__(**kwargs)
self.client_app_id = client_app_id
self.server_app_id = server_app_id
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@
# regenerated.
# --------------------------------------------------------------------------

VERSION = "4.2.2"
VERSION = "4.1.0"