Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Tracing typing #31943

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Fix Tracing typing #31943

merged 4 commits into from
Sep 5, 2023

Conversation

lmazuel
Copy link
Member

@lmazuel lmazuel commented Sep 5, 2023 •
edited
Loading

Fix #31564

image

@azure-sdk
Copy link
Collaborator

azure-sdk commented Sep 5, 2023 •
edited
Loading

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-core
azure-core-tracing-opentelemetry

pvaneck
pvaneck approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@pvaneck pvaneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the typing updates! Great having both mypy and pyright happy when setting the tracing implementation.

@lmazuel
Copy link
Member Author

lmazuel commented Sep 5, 2023

Merging as the error is a pytest collection error involving cryptography, nothing to do with this PR

@lmazuel lmazuel merged commit a9d3c89 into main Sep 5, 2023
@lmazuel lmazuel deleted the tracing_change_context branch September 5, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristapratico kristapratico kristapratico left review comments

@pvaneck pvaneck pvaneck approved these changes

@annatisch annatisch annatisch approved these changes

@johanste johanste Awaiting requested review from johanste johanste is a code owner

@xiangyan99 xiangyan99 Awaiting requested review from xiangyan99 xiangyan99 is a code owner

@tjprescott tjprescott Awaiting requested review from tjprescott

@iscai-msft iscai-msft Awaiting requested review from iscai-msft iscai-msft is a code owner

@kashifkhan kashifkhan Awaiting requested review from kashifkhan kashifkhan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mypy complains with new version of azure-core
5 participants
@lmazuel @azure-sdk @pvaneck @annatisch @kristapratico