-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ml] Address apiview docstring comments for 1.10.0 release #31709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diondrapeck
requested review from
DouglasXiaoMS,
TonyJ1,
wangchao1230,
paulshealy1,
singankit,
luigiw,
kdestin,
MilesHolland,
needuv,
nemanjarajic and
nthandeMS
as code owners
August 18, 2023 01:25
API change check APIView has identified API level changes in this PR and created following API reviews. |
MilesHolland
approved these changes
Aug 18, 2023
kdestin
approved these changes
Aug 18, 2023
diondrapeck
changed the title
Address apiview comments
[ml] Address apiview docstring comments for 1.10.0 release
Aug 18, 2023
MilesHolland
pushed a commit
to MilesHolland/azure-sdk-for-python
that referenced
this pull request
Aug 18, 2023
* Remove extra/incorrect load_component methods and fix example * Fix 'integer' typo to 'int' * Fix 'integer' typo to 'int', change keyword args from param * Remove parent class args from docstring * Fix load_component example
MilesHolland
added a commit
that referenced
this pull request
Aug 21, 2023
* Enable feature store to provision network and flip public network access (#31645) * Enable feature store to provision network and flip public network access * Format the code * Update provision network to include spark (#31685) * [FeatureStore] simple feature store setup (#31468) * simple feature store initial commit * add unit tests * add e2e tests * update * test * test * update * remove print * update * update * update * u * update template * update template * update * add dependency * [ml] Address apiview docstring comments for 1.10.0 release (#31709) * Remove extra/incorrect load_component methods and fix example * Fix 'integer' typo to 'int' * Fix 'integer' typo to 'int', change keyword args from param * Remove parent class args from docstring * Fix load_component example * Update project template (#31704) * minor fix (#31706) --------- Co-authored-by: Fred Li <51424245+fredms@users.noreply.github.com> Co-authored-by: runhli <87873226+runhli@users.noreply.github.com> Co-authored-by: Diondra <16376603+diondrapeck@users.noreply.github.com> Co-authored-by: ZhidaLiu <zhili@microsoft.com>
lmazuel
pushed a commit
that referenced
this pull request
Aug 21, 2023
* Remove extra/incorrect load_component methods and fix example * Fix 'integer' typo to 'int' * Fix 'integer' typo to 'int', change keyword args from param * Remove parent class args from docstring * Fix load_component example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines