Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS JobRouter] Review feedback items #31083

Merged
merged 8 commits into from
Jul 12, 2023

Conversation

sarkar-rajarshi
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-communication-jobrouter

@sarkar-rajarshi sarkar-rajarshi marked this pull request as ready for review July 12, 2023 22:31
@sarkar-rajarshi sarkar-rajarshi enabled auto-merge (squash) July 12, 2023 22:32
@sarkar-rajarshi sarkar-rajarshi disabled auto-merge July 12, 2023 22:39
@sarkar-rajarshi sarkar-rajarshi enabled auto-merge (squash) July 12, 2023 22:43
@sarkar-rajarshi sarkar-rajarshi merged commit 9904083 into main Jul 12, 2023
@sarkar-rajarshi sarkar-rajarshi deleted the rsarkar/acs-jobrouter-review-feedback branch July 12, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants