Azure.monitor.opentelemetry.exporter replace pkg_resources with importlib.metadata #30018
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Azure.monitor.opentelemetry.exporter is currently using pkg_resources to find the version of opentelemetry sdk.
Usage pkg_resources is discouraged and the same functionality is available in importlib.metadata in the std lib.
The main problem with pkg_resources is that import is very slow since it scans all installed packages at import. Opentelemetry it self dropped the usage of it in 1.17 this means that is a Azure exported telemetry config this package is now the only one that imports pkg_resources.
Since this functionality was added to the std lib in 3.8 we use the official backported package for 3.7. Note that opentelemetry already depends on this package in a similar way.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines