Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding in some functionality to use different clouds #28528

Merged
merged 25 commits into from
Feb 7, 2023
Merged

Adding in some functionality to use different clouds #28528

merged 25 commits into from
Feb 7, 2023

Conversation

brownma-ms
Copy link
Contributor

@brownma-ms brownma-ms commented Jan 30, 2023 •
edited
Loading

This support is needed for the air gapped environments. There are three ways to add a new cloud environment. These were all taken from examples in the v1 sdk.

  1. The SDK will look for a default configuration file and try to find
    cloud environments in there.
  2. If you set an environment variable called ARM_METADATA_URL, it will
    look there for cloud configurations. If you do not set this, it will
    use a default URL in the _azure_environments.py file to find them.
  3. The SDK exposes two new functions, add_cloud which will add the new
    configuration to the configuration file mentioned in number 1, and
    update_cloud which will update the added configuration.

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added Machine Learning customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Jan 30, 2023
@ghost
Copy link

ghost commented Jan 30, 2023

Thank you for your contribution brownma-ms! We will review the pull request and get back to you soon.

@alexsuttonms
Copy link

Typo in item 1--SKD not SDK

@brownma-ms
Adding in some functionality to use different clouds
f5657de 
This support is needed for the air gapped environments.  There are three
ways to add a new cloud environment.  These were all taken from examples
in the v1 sdk.

1) The SDK will look for a default configuration file and try to find
   cloud environments in there.
2) If you set an environment variable called ARM_METADATA_URL, it will
   look there for cloud configurations.  If you do not set this, it will
   use a default URL in the _azure_environments.py file to find them.
3) The SDK exposes two new functions, add_cloud which will add the new
   configuration to the configuration file mentioned in Azure#1, and
   update_cloud which will update the added configuration.
singankit
singankit reviewed Jan 30, 2023
View reviewed changes
sdk/ml/azure-ai-ml/azure/ai/ml/_azure_environments.py Outdated Show resolved Hide resolved
sdk/ml/azure-ai-ml/azure/ai/ml/_azure_environments.py Outdated Show resolved Hide resolved
sdk/ml/azure-ai-ml/azure/ai/ml/__init__.py Outdated Show resolved Hide resolved
sdk/ml/azure-ai-ml/azure/ai/ml/entities/_manage_clouds.py Outdated Show resolved Hide resolved
sdk/ml/azure-ai-ml/azure/ai/ml/_azure_environments.py Outdated Show resolved Hide resolved
sdk/ml/azure-ai-ml/azure/ai/ml/_azure_environments.py Outdated Show resolved Hide resolved
sdk/ml/azure-ai-ml/azure/ai/ml/_azure_environments.py Outdated Show resolved Hide resolved
sdk/ml/azure-ai-ml/azure/ai/ml/_azure_environments.py Outdated Show resolved Hide resolved
sdk/ml/azure-ai-ml/azure/ai/ml/_azure_environments.py Outdated Show resolved Hide resolved
@brownma-ms brownma-ms force-pushed the brownma/moreclouds branch 3 times, most recently from dc2e596 to 4360dd6 Compare February 1, 2023 19:41
@brownma-ms
Copy link
Contributor Author

brownma-ms commented Feb 6, 2023 •
edited
Loading

@microsoft-github-policy-service agree company="Microsoft"

@brownma-ms brownma-ms force-pushed the brownma/moreclouds branch 2 times, most recently from a308722 to fdc9a96 Compare February 7, 2023 13:58
harneetvirk
harneetvirk approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@harneetvirk harneetvirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a sample for using this feature of loading new cloud if possible. It can be part of the following PR.

@harneetvirk harneetvirk merged commit c3b7b30 into Azure:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronalds-cmd ronalds-cmd ronalds-cmd approved these changes

@singankit singankit singankit left review comments

@paulshealy1 paulshealy1 paulshealy1 left review comments

@derekehyatt derekehyatt derekehyatt left review comments

@harneetvirk harneetvirk harneetvirk approved these changes

@theodoreschen theodoreschen theodoreschen approved these changes

@diondrapeck diondrapeck Awaiting requested review from diondrapeck

@luigiw luigiw Awaiting requested review from luigiw

@kdestin kdestin Awaiting requested review from kdestin

@MilesHolland MilesHolland Awaiting requested review from MilesHolland

@needuv needuv Awaiting requested review from needuv

@nthandeMS nthandeMS Awaiting requested review from nthandeMS

Assignees
No one assigned
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Machine Learning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@brownma-ms @alexsuttonms @theodoreschen @derekehyatt @harneetvirk @paulshealy1 @singankit @ronalds-cmd @ronaldshaw-work