Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated documentation to reflect need for zone_type parameter when creating a zone #2232

Merged
merged 1 commit into from
Aug 1, 2018

Conversation

racingferret
Copy link
Contributor

With the inclusion of private DNS zones to the SDK, the documentation needs to reflect the additional parameter required when defining a zone. Following the documentation in the examples results in the following exception:

...
File "/usr/local/lib/python2.7/dist-packages/azure/mgmt/dns/operations/zones_operations.py", line 100, in create_or_update
body_content = self._serialize.body(parameters, 'Zone')
File "/usr/local/lib/python2.7/dist-packages/msrest/serialization.py", line 475, in body
raise errors[0]
msrest.exceptions.ValidationError: Parameter 'Zone.zone_type' can not be None.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@codecov-io
Copy link

codecov-io commented Mar 20, 2018

Codecov Report

Merging #2232 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2232   +/-   ##
=======================================
  Coverage   52.12%   52.12%           
=======================================
  Files        5625     5625           
  Lines      134589   134589           
=======================================
  Hits        70155    70155           
  Misses      64434    64434

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01b6297...b07a62b. Read the comment docs.

@lmazuel
Copy link
Member

lmazuel commented Mar 20, 2018

Hi @racingferret
You're totally right, but this is the RC client. And this sample has moved here (which needs to be adapted as well):
https://docs.microsoft.com/en-us/python/api/overview/azure/dns?view=azure-python

Since preview clients are installed only if "--pre" is provided, I prefer to keep the sample in sync with latest stable for now. But definitely keep your PR.
Thanks for your contribution!

@lmazuel
Copy link
Member

lmazuel commented Aug 1, 2018

DNS 2.0.0 will be released in a few seconds, so merge it now.
Thanks @racingferret again for the PR!

@lmazuel lmazuel merged commit 667ff3f into Azure:master Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants