Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[formrecognizer] Refactor DAC tests into separate files #21968

Merged
merged 12 commits into from
Dec 9, 2021

Conversation

catalinaperalta
Copy link
Member

@catalinaperalta catalinaperalta commented Dec 1, 2021

This PR refactors DAC tests into separate files, a separate PR will separate DMAC tests.
Part of #20862, #20849 these issues will be closed in the DMAC tests PR.
Part of #16689 : the omnibus methods have greatly helped in reducing redundant tests that previously existed for all prebuilt verticals, also previous PRs some redundant tests from the v2.1 test set.

Pending issues: #22025

@catalinaperalta catalinaperalta self-assigned this Dec 1, 2021
@catalinaperalta catalinaperalta changed the title [formrecognizer] Refactor DAC and DMAC tests into separate files [formrecognizer] Refactor DAC tests into separate files Dec 8, 2021
@catalinaperalta catalinaperalta marked this pull request as ready for review December 8, 2021 23:48
Copy link
Member

@kristapratico kristapratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay LGTM! this feels a lot cleaner ✨

@catalinaperalta catalinaperalta merged commit 4c74111 into Azure:main Dec 9, 2021
@catalinaperalta catalinaperalta deleted the mq/refactorTests branch December 9, 2021 21:28
hildurhodd pushed a commit to hildurhodd/azure-sdk-for-python that referenced this pull request Jan 4, 2022
* refactor async prebuilt analyze tests

* clean up refactored tests and recordings

* refactor async url analyze prebuilt tests

* add recordings for async url tests

* refactor sync prebuilt analyze tests

* add new recordings, delete old ones

* refactor sync analyze prebuilt from url tests

* add new url test recordings and delete old ones

* remove unused imports

* rename general document and layout tests

* update general document and layout recordings

* refactor custom documents tests, update recordings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants