Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR containerservices/resource-manager] [AKS] specify byte format for base64-encoded kubeconfig #2195

Merged

Conversation

AutorestCI
Copy link
Contributor

[AKS] specify byte format for base64-encoded kubeconfig
@AutorestCI
Copy link
Contributor Author

AutorestCI commented Mar 16, 2018

(message created by the CI based on PR content)

Installation instruction

Package azure-mgmt-containerservice

You can install the package azure-mgmt-containerservice of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_2669#egg=azure-mgmt-containerservice&subdirectory=azure-mgmt-containerservice"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_2669#egg=azure-mgmt-containerservice&subdirectory=azure-mgmt-containerservice"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_2669
  • pip install -e ./azure-mgmt-containerservice

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_2669
  • pip wheel --no-deps ./azure-mgmt-containerservice

Direct download

Your files can be directly downloaded here:

@codecov-io
Copy link

Codecov Report

Merging #2195 into restapi_auto_containerservices/resource-manager will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@                                 Coverage Diff                                 @@
##           restapi_auto_containerservices/resource-manager    #2195      +/-   ##
===================================================================================
- Coverage                                            52.12%    52.1%   -0.02%     
===================================================================================
  Files                                                 5588     5588              
  Lines                                               133778   133731      -47     
===================================================================================
- Hits                                                 69726    69679      -47     
  Misses                                               64052    64052
Impacted Files Coverage Δ
...ice/models/container_service_agent_pool_profile.py 100% <ø> (ø) ⬆️
...ice/models/container_service_master_profile_py3.py 100% <ø> (ø) ⬆️
...models/container_service_agent_pool_profile_py3.py 100% <ø> (ø) ⬆️
...erservice/models/container_service_client_enums.py 100% <ø> (ø) ⬆️
...service/models/container_service_master_profile.py 100% <ø> (ø) ⬆️
...erservice/models/managed_cluster_access_profile.py 71.42% <ø> (ø) ⬆️
...rvice/models/managed_cluster_access_profile_py3.py 71.42% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be39ac2...bd5f1fa. Read the comment docs.

@mboersma
Copy link
Member

Looking at the diff, this PR appears to undo some of the changes in #2185. Specifically, the VM sizes list looks like it's reverting to what we had before. Do we need to re-regenerate this PR?

@lmazuel
Copy link
Member

lmazuel commented Mar 16, 2018

@mboersma nope, ths squash will do it fine

@lmazuel lmazuel merged commit 19b8c4b into restapi_auto_containerservices/resource-manager Mar 16, 2018
@lmazuel lmazuel deleted the restapi_auto_2669 branch March 16, 2018 18:52
AutorestCI added a commit that referenced this pull request May 25, 2018
[AKS] specify byte format for base64-encoded kubeconfig
lmazuel pushed a commit that referenced this pull request Jun 5, 2018
* Generated from 8a259e0b55e6b455d866afb9d3dc1fa88e032193 (#2185)

Sync up ACS VM sizes with AKS sizes

* Generated from 63832619ea68b0f3b93c37f2ac2be54a5b3dba83 (#2195)

[AKS] specify byte format for base64-encoded kubeconfig

* Generated from 8906ba9709671ec120effb24013ed55425576606 (#2551)

Sync ACS & AKS' VM sizes lists

* [AutoPR containerservices/resource-manager] [AKS] add POST endpoint for fetching accessProfiles (#2583)

* Generated from 3c1665f522ece941d8c827b3e8ee539c2cdaf846

[AKS] add POST endpoint for fetching accessProfiles

* Generated from a86af5dd1b974ecc3b58e95efc228497137d79a3

Mark GET endpoint for accessProfiles as deprecated

* Generated from 14544bfbd10b7319f64f1174b84801347ace5dc9

Bump package version

* Generated from a69eb4b470374683c3bc4e86491aa60ae0a161ea

Rename to GetAccessProfile

* ACS auto packaging

* azure-mgmt-containerservice 4.0.0

* [AutoPR containerservices/resource-manager] [AKS] add new 2018-03-31 API  (#2631)

* Generated from e365e10741ba688b8c3b39b67986e2b6e06e4ddc

Rename to ManagedClusterAgentPoolProfile.

Its fields have diverged from ContainerServiceAgentPoolProfile.

* Generated from 3047e9e632f7c44d4a88f3c768fc1de4dd9f40ec

Py version

* Generated from d61dfda40f6a7498040fee441c1b23cb6a1bc01a

Incorporated review comments

* Generated from 33469ca0e594d658a51b73dcb5e7f9526c768024 (#2684)

Rename to "Operation" from "ComputeOperation"

* Generated from 75bc2c7e14e354c5d782f6e001cf865a8d55cfdb (#2682)

[AKS] remove maxPods default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants