Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EventHubs] add fixed backoff retry mode #21884

Merged
merged 10 commits into from
Jan 4, 2022
Merged

[EventHubs] add fixed backoff retry mode #21884

merged 10 commits into from
Jan 4, 2022

Conversation

swathipil
Copy link
Member

fixes: #8670

@ghost ghost added the Event Hubs label Nov 24, 2021
@azure-sdk
Copy link
Collaborator

API changes have been detected in azure-eventhub. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in azure-eventhub-checkpointstoreblob-aio. You can review API changes here

API changes

-             api_version: str, 
+             api_version: str = ..., 
-             secondary_hostname: str, 
+             secondary_hostname: str = ..., 
-             api_version: str, 
+             api_version: str = ..., 
-             secondary_hostname: str, 
+             secondary_hostname: str = ...,

@azure-sdk
Copy link
Collaborator

API changes have been detected in azure-eventhub-checkpointstoreblob. You can review API changes here

API changes

-             api_version: str, 
-             secondary_hostname: str, 
+             api_version: str = ..., 
+             secondary_hostname: str = ..., 
-             api_version: str, 
-             secondary_hostname: str, 
+             api_version: str = ..., 
+             secondary_hostname: str = ...,

@swathipil
Copy link
Member Author

/azp run python - eventhub - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

API changes have been detected in azure-eventhub. You can review API changes here

yunhaoling
yunhaoling reviewed Jan 3, 2022
View reviewed changes
sdk/eventhub/azure-eventhub/azure/eventhub/__init__.py
@@ -33,5 +34,6 @@
"LoadBalancingStrategy",
"PartitionContext",
"parse_connection_string",
"EventHubConnectionStringProperties"
"EventHubConnectionStringProperties",
"RetryMode"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There're API changes, remember to get @annatisch to take a look at the API view before CC day :)

yunhaoling
yunhaoling reviewed Jan 3, 2022
View reviewed changes
Copy link
Contributor

@yunhaoling yunhaoling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks great, thanks!
left some minor comments

@swathipil
Copy link
Member Author

/azp run python - eventhub - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@swathipil swathipil requested a review from yunhaoling January 3, 2022 23:52
@swathipil
Copy link
Member Author

/azp run python - eventhub - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

yunhaoling
yunhaoling approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@yunhaoling yunhaoling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this PR, but I would recommend letting @annatisch review the API changes first before merging it to avoid rolling back.

@swathipil swathipil mentioned this pull request Jan 4, 2022
Merged
@swathipil swathipil merged commit 2fce666 into Azure:main Jan 4, 2022
@swathipil swathipil deleted the swathipil/eh/retry-linear-backoff branch January 4, 2022 17:53
@swathipil swathipil mentioned this pull request Jan 6, 2022
Merged
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
@swathipil @rakshith91
[EventHubs] add fixed backoff retry mode (Azure#21884)
3a6b3e9 
* sync retry mode impl

* async impl

* add test

* pylint

* lint

* adams comments

* lint

* adams comments

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunhaoling yunhaoling yunhaoling approved these changes

@annatisch annatisch Awaiting requested review from annatisch annatisch is a code owner

@rakshith91 rakshith91 Awaiting requested review from rakshith91

Assignees
No one assigned
Labels
Event Hubs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[EventHubs] Provide an linear(fixed) backoff option for retry
3 participants
@swathipil @azure-sdk @yunhaoling