-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
respect text encoding specified in argument (#20795) #20796
Conversation
Thank you for your contribution ryohji! We will review the pull request and get back to you soon. |
Thank you for the contributing. We are reviewing the change and will keep you updated. |
mimetype = aiohttp.helpers.parse_mimetype(ctype) | ||
|
||
encoding = mimetype.parameters.get("charset") | ||
if encoding: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why you put if encoding in if not encoding: statement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is original implementation's L.317.
On original L.316, the method overwrites encoding
if it explicitly specified by callers. (And it might be None
; this is the reason why this if encoding:
lives in if not encoding:
statement)
I thought that original L.313 to L.336 is the guard for encoding = None
so just add L.313 if not encoding:
and indented following lines.
But reviewing my own code, this None
check might be enough just before original L.316.
So I re-write patch and force-pushed it.
Thanks to your review!
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
/check-enforcer override |
/check-enforcer evaluate |
/check-enforcer reset |
/check-enforcer evaluate |
Thanks for the contribution. If you don't mind, I will close this one and use #20999 to track. |
OK, I agreed. Thanks to your review. |
If explicitly specified, respect
encoding
parameter ofAioHttpTransportResponse#text
method to resolve the issue #20795.