-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Errors and Tables in Query #20658
Conversation
rakshith91
commented
Sep 12, 2021
•
edited
Loading
edited
- Introduce QueryPartialErrorException
- Throw errors as discussed here https://gist.github.com/rakshith91/d08caf649feac0081703d4c1e5850326
- Add iterator to the LogsQueryResults to iterate over tables.
f8df0d9
to
56ecff3
Compare
/azp run python - monitor - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
sdk/monitor/azure-monitor-query/azure/monitor/query/_generated/models/_models_py3.py
Outdated
Show resolved
Hide resolved
/azp run python - monitor - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
# -------------------------------------------------------------------------- | ||
from azure.core.exceptions import HttpResponseError | ||
|
||
class LogsQueryError(object): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it an AzureError?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this need not be an azure error.
raise raise_error(message=exception.message, response=exception.response) | ||
|
||
def order_results(request_order, mapping, obj): | ||
def order_results(request_order, mapping, obj, err, allow_partial_errors=False): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to put allow_partial_errors into kwargs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
normally i would say yes - but here, i don't see the kwargs expanding anytime soon - plus this is an internal method, so we can change it if we think it's necessary
@@ -90,3 +98,22 @@ def native_col_type(col_type, value): | |||
|
|||
def process_row(col_types, row): | |||
return [native_col_type(col_types[ind], val) for ind, val in enumerate(row)] | |||
|
|||
def process_error(error): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, error is an HttpResponseError, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes that is correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you help me understand what is this method for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, made some small changes to this - missed a commit earlier
this is to convert the model into the logsqueryerror intead of generated internal model.
innererror=cls._from_generated(generated.innererror) if generated.innererror else None, | ||
additional_properties=generated.additional_properties, | ||
details=details, | ||
is_error=True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need it? (is_error=True)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes - we return Union[LogsQueryResult, LogsQueryError]
for the batch api - the workflow would be
if result.is_error:
# handle logsquery erroe
elif not result.is_error:
# hanfle log query result
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I read correctly, we don't honor "is_error" in ctor.
def __init__(
self,
**kwargs
):
self.code = kwargs.get('code', None)
self.message = kwargs.get('message', None)
self.details = kwargs.get('details', None)
self.innererror = kwargs.get('innererror', None)
self.additional_properties = kwargs.get('additional_properties', None)
self.is_error = True
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that is correct - this is always True
for a LogsQueryError
and always False
for a LogsQueryResult
- it's very similar to what we have in text analytics against DocumentError
Update: removed from the ctor
a5b8e4b
to
92631d4
Compare
/azp run python - monitor - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run python - monitor - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run python - monitor - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run python - monitor - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run python - monitor - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
res = obj._from_generated(item.body) # pylint: disable=protected-access | ||
res.partial_error = err._from_generated(error) # pylint: disable=protected-access | ||
results.append(res) | ||
else: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we raise if allow_partial_errors = False and there is error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no - in case of batch, we return the error object instead of the result object
of course, we raise when something fatal happens (like auth error for instance)
commit 7832c5a Author: Azure CLI Bot <azclibot@microsoft.com> Date: Sat Sep 18 09:34:11 2021 +0800 [AutoRelease] t2-eventhub-2021-09-17-55263(Do not merge) (#20739) * CodeGen from PR 15979 in Azure/azure-rest-api-specs EventHub: Added missing Cluster API in 2021-06-01-preview (#15979) * Added missing Cluster APIs to 2021-01-01-preview * added cluster API in 2021-06-01-preview * updated lint errors * update 1 * added listbysubscription * fixed ModelValidation Co-authored-by: v-ajnava <v-ajnava@microsoft.com> * version,CHANGELOG Co-authored-by: SDKAuto <sdkautomation@microsoft.com> Co-authored-by: v-ajnava <v-ajnava@microsoft.com> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> commit 29d98e8 Author: Chidozie Ononiwu (His Righteousness) <31145988+chidozieononiwu@users.noreply.github.com> Date: Fri Sep 17 17:27:57 2021 -0700 Fix broken link in python repo (#20746) commit cbfacbd Author: Xiaoxi Fu <49707495+xiafu-msft@users.noreply.github.com> Date: Fri Sep 17 14:04:28 2021 -0700 [Storage]Unify service version and update changelog (#20723) * [Storage]Unify service version and update changelog * fix test commit ea5ecea Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Fri Sep 17 10:19:31 2021 -0700 Sync eng/common directory with azure-sdk-tools for PR 2010 (#20729) * Remove empty sections in changelog entry as part of prepare release * Update SECTIONS_HEADER_REGEX to accomodate various header levels Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> commit 9b63801 Author: Azure CLI Bot <azclibot@microsoft.com> Date: Fri Sep 17 15:00:44 2021 +0800 [AutoRelease] t2-azurearcdata-2021-09-15-74995 (#20714) * CodeGen from PR 15874 in Azure/azure-rest-api-specs Adding 202 Accepted for deletion call (#15874) * Adding 202 for deletion call * Adding headers to suppress warnings * version,CHANGELOG Co-authored-by: SDKAuto <sdkautomation@microsoft.com> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> commit 0645f49 Author: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> Date: Thu Sep 16 15:58:10 2021 -0700 [Test Proxy] Make add_sanitizer a module-level method (#20701) commit ddf49b1 Author: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> Date: Thu Sep 16 15:27:08 2021 -0700 [Test proxy] Add migration guide (#20469) commit e116660 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Thu Sep 16 12:33:48 2021 -0700 Sync eng/common directory with azure-sdk-tools for PR 2011 (#20702) * Common pipeline template and script to detect API changes * Cahnges as per review comments * Review comment changes * CCahgnes as per review comments * Show warning for list of failed packages to detect API changes * Apply suggestions from code review Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: praveenkuttappan <prmarott@microsoft.com> Co-authored-by: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> commit 44e2acf Author: Scott Beddall <45376673+scbedd@users.noreply.github.com> Date: Thu Sep 16 10:57:23 2021 -0700 protobuf to handle python 2.7 issues (#20725) commit 81c6aa0 Author: Xiang Yan <xiangsjtu@gmail.com> Date: Thu Sep 16 08:33:08 2021 -0700 add troubleshoot doc (#20684) * add troubleshoot doc * fix typo * update * update * update * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: Charles Lowell <chlowe@microsoft.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: Charles Lowell <chlowe@microsoft.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: Charles Lowell <chlowe@microsoft.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: Charles Lowell <chlowe@microsoft.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: Charles Lowell <chlowe@microsoft.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: Charles Lowell <chlowe@microsoft.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: Charles Lowell <chlowe@microsoft.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: Charles Lowell <chlowe@microsoft.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: Charles Lowell <chlowe@microsoft.com> * Update Troubleshoot.md * update error log Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> Co-authored-by: Charles Lowell <chlowe@microsoft.com> commit 87e0f99 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Wed Sep 15 15:32:41 2021 -0700 Sync eng/common directory with azure-sdk-tools for PR 2016 (#20706) * Make ServiceName optional for verify-changelog In cases like go where we don't pass a service name having this default to "not-specified" breaks things so we should allow for ServiceName and/or ServiceDirectory to be empty. * Put quotes around the strings to allow for empty Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> commit c80e26e Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Wed Sep 15 12:45:42 2021 -0700 Sync eng/common directory with azure-sdk-tools for PR 2009 (#20672) * Skip PSModule caching in container jobs * Add succeeded check to condition Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> Co-authored-by: Ben Broderick Phillips <ben@benbp.net> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> commit 1efff7f Author: Travis Prescott <tjprescott@users.noreply.github.com> Date: Wed Sep 15 10:53:42 2021 -0700 [Search] Add skillset validation (#20669) * Add client-side validation and test. * Add skillset validation test. * Make code more Pythonic. commit 6a06b0e Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Tue Sep 14 16:56:19 2021 -0700 Add for multiple levels of Atx Headers in the CHANGELOG.md (#20694) Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> commit 3fdbaa7 Author: swathipil <76007337+swathipil@users.noreply.github.com> Date: Tue Sep 14 16:27:06 2021 -0700 [EventHub] update arm template with storage conn str (#20376) * update test resources * fix * fix failing tests * adams comments * pylint * remove dateutil * adams comments * nit commit 279e7eb Author: Rakshith Bhyravabhotla <sabhyrav@microsoft.com> Date: Tue Sep 14 15:22:05 2021 -0700 Add a new row type in query (#20685) * Add row type * Add a new row type * add test * lint * Apply suggestions from code review * changes commit 5016742 Author: luc <44377201+LuChen-Microsoft@users.noreply.github.com> Date: Tue Sep 14 13:09:43 2021 -0700 Update changelog date (#20686) * update swagger * update release date commit 080f88d Author: swathipil <76007337+swathipil@users.noreply.github.com> Date: Tue Sep 14 13:01:32 2021 -0700 [SchemaRegistry] update type of `schema` in `serialize` (#20683) * update type * update sample naming commit 599a099 Author: Rakshith Bhyravabhotla <sabhyrav@microsoft.com> Date: Tue Sep 14 09:41:19 2021 -0700 Handle Errors and Tables in Query (#20658) * initial commit * batch set * batch * tests + changes * more tests * lint * changelog * Apply suggestions from code review * comment * lint * querry * comments commit 3252969 Author: swathipil <76007337+swathipil@users.noreply.github.com> Date: Tue Sep 14 09:17:18 2021 -0700 [SchemaRegistry] remove codec param in serializer (#20671) * remove codec * changelog commit 27b7e75 Author: msyyc <70930885+msyyc@users.noreply.github.com> Date: Tue Sep 14 16:52:11 2021 +0800 Update change_log.py (#20680) commit fd80cb7 Author: Azure CLI Bot <azclibot@microsoft.com> Date: Tue Sep 14 13:52:13 2021 +0800 [AutoRelease] t2-storage-2021-09-14-45016(Do not merge) (#20678) * CodeGen from PR 15627 in Azure/azure-rest-api-specs [SRP] 2021-06-01 Swagger Api (#15627) * Add June21 Swagger Api version, Updated Readme files * adding abort and hnson migration swagger API * swagger: marking requesttype as required parameter for hns onmigration * Added new PublicNetworkAccess property to swagger spec * Add enableNfsV3RootSquash and enableNfsV3AllSquash to June21 swagger * Add Account Level VLW Swagger changes and example * Update Blob Inventory Api comment to include AccessTierInferred and Tags * Rename HnsOn to hierarchical namespace * [Swagger] [June21] Added defaultToOAuthAuthentication to swagger spec * Update Spell check custom words list. Correct incorrect spellings * Add missing refrences to PublicNetworkAccess Examples * Add required type:object, Add default return type for hns migration apis * Prettier tool update to storage.json * Add update account with immutability policy example * Removed StorageFileDataSmbShareOwner as Server side does not support it * Add AllowProtectedAppendWritesAll feature changes with example * Updated enum values and description for PublicNetworkAccess * Add type:object to ProtectedAppendWritesHistory ; Spellcheck * version,CHANGELOG Co-authored-by: SDKAuto <sdkautomation@microsoft.com> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> commit 3eb0af9 Author: William Harding <william.jeffrey.harding@gmail.com> Date: Mon Sep 13 16:06:06 2021 -0700 Updated notebooks to make them more "general" (#15660) * Updated notebooks to make them more "general" * updated gitignore, added models, updated path * reverted gitignore * reverting gitignore * Renamed some files, changed model id to be more generic commit 69be40d Author: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> Date: Mon Sep 13 15:35:26 2021 -0700 [Key Vault] Update new test resource script (#20663) commit ce307fe Author: Scott Addie <10702007+scottaddie@users.noreply.github.com> Date: Mon Sep 13 17:23:16 2021 -0500 Final consistency review of Monitor Query README (#20667) * Final consistency review of Monitor Query README * Add rate limits section commit c4d64b2 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Mon Sep 13 13:50:44 2021 -0700 Sync eng/common directory with azure-sdk-tools for PR 1979 (#20666) * Move logic for removing empty sections to ChangeLog-Operations.ps1 * Refactor sections regex * Add SanitizeEntry parameter Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> commit 3a537c9 Author: Travis Prescott <tjprescott@users.noreply.github.com> Date: Mon Sep 13 13:45:21 2021 -0700 Update docstrings for custom models. (#20592) commit 90ce516 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Mon Sep 13 13:06:02 2021 -0700 Fix SemVer.ToString to handle v0 case (#20665) Since we are treating v0 versions as prerelease we need to make sure we don't accidently start to add the bogus prerelease label in cases where we call ToString() on the version. Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> commit dd67039 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Mon Sep 13 13:04:52 2021 -0700 Sync eng/common directory with azure-sdk-tools for PR 1946 (#20656) * Add ability to exit gracefully when all files in the diff are excluded * Address case where cspell exits with an error when all files from the 'files' config list are excluded by the expressions in 'ignorePaths' * Add tests * Review feedback: impl goes at the bottom and should be treated as a script, logic for testing should happen above that and exit appropriately if running tests * Import common instead of logging * Enable strict mode Co-authored-by: Daniel Jurek <djurek@microsoft.com> commit 7b2aeaf Author: swathipil <76007337+swathipil@users.noreply.github.com> Date: Mon Sep 13 10:47:42 2021 -0700 [EventHubs] update test to test async producer (#19892) - call async Producer for testing/improving code coverage - remove passing in fake kwarg to PartitionContext; untested lines in PartitionContext can only be tested with a user implemented CheckpointStore class, so not worrying about this commit 8f28e2a Author: Leighton Chen <lechen@microsoft.com> Date: Mon Sep 13 10:37:18 2021 -0700 [Monitor exporter] Add OTLP and dual exporter scenario to samples (#20634) * rpc * samples commit 5450368 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Mon Sep 13 09:21:54 2021 -0700 Sync eng/common directory with azure-sdk-tools for PR 1983 (#20618) * Doc Updates and Revisions for External Use The focus of these changes is to revise the script to better support use by external contributors and others outside of the Azure SDK ecosystem and without access to the Microsoft AAD Tenant. Changes include: - Creation of a new Test Application service principal is now possible from a non-Microsoft AAD tenant. - When a new Test Application principal is created, the principle of least privilege is now applied; the new Test Application is granted ownership of the resource group associated with the test resources and no longer has access to any other resources in the subscription. - If an existing Test Application principal is specified, it will be assigned ownership of the resource group created. This supports using a Test Application principal without privileges at the subscription-level. - When no provisioner is specified, the script is now executed in the context of the caller rather than the Test Application principal. This supports using a Test Application principal that has restricted privileges and better aligns to the purpose of the Test Application principal. - The `$TestApplicationOid` is now explicitly bound at the time a new Test Application principal is created rather than having to query for it later. - Common error scenarios resulting from lack of permissions now provide messaging with more context of why the failure occurred and suggest remediation. - Added new examples to illustrate the common call patterns needed by external contributors running the script, outside of the Microsoft tenant and Azure SDK ecosystem. - Documentation has been enhanced with additional context to detail the permissions and roles assigned by the script. - Added documentation details for Bicep template use. * Add the provisioner OID to the deployment params Key Vault needs this to deploy Managed HSMs. There's a corresponding change necessary in test-resources.json I'll roll out across languages. * Fixing typos and spelling mistakes Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Co-authored-by: Heath Stewart <heaths@microsoft.com> commit b7b7e36 Author: Travis Prescott <tjprescott@users.noreply.github.com> Date: Mon Sep 13 09:10:38 2021 -0700 [Search] Update SearchClient.search API (#20602) * Update SearchClient.search API. * Update CHANGELOG and async SearchClient. * Update parameter parsing for omitted values. * Code review comments and linter fixes. commit 4048684 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Sun Sep 12 15:49:22 2021 -0700 Increment version for monitor releases (#20635) Increment package version after release of azure-monitor-query
commit 7832c5a Author: Azure CLI Bot <azclibot@microsoft.com> Date: Sat Sep 18 09:34:11 2021 +0800 [AutoRelease] t2-eventhub-2021-09-17-55263(Do not merge) (#20739) * CodeGen from PR 15979 in Azure/azure-rest-api-specs EventHub: Added missing Cluster API in 2021-06-01-preview (#15979) * Added missing Cluster APIs to 2021-01-01-preview * added cluster API in 2021-06-01-preview * updated lint errors * update 1 * added listbysubscription * fixed ModelValidation Co-authored-by: v-ajnava <v-ajnava@microsoft.com> * version,CHANGELOG Co-authored-by: SDKAuto <sdkautomation@microsoft.com> Co-authored-by: v-ajnava <v-ajnava@microsoft.com> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> commit 29d98e8 Author: Chidozie Ononiwu (His Righteousness) <31145988+chidozieononiwu@users.noreply.github.com> Date: Fri Sep 17 17:27:57 2021 -0700 Fix broken link in python repo (#20746) commit cbfacbd Author: Xiaoxi Fu <49707495+xiafu-msft@users.noreply.github.com> Date: Fri Sep 17 14:04:28 2021 -0700 [Storage]Unify service version and update changelog (#20723) * [Storage]Unify service version and update changelog * fix test commit ea5ecea Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Fri Sep 17 10:19:31 2021 -0700 Sync eng/common directory with azure-sdk-tools for PR 2010 (#20729) * Remove empty sections in changelog entry as part of prepare release * Update SECTIONS_HEADER_REGEX to accomodate various header levels Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> commit 9b63801 Author: Azure CLI Bot <azclibot@microsoft.com> Date: Fri Sep 17 15:00:44 2021 +0800 [AutoRelease] t2-azurearcdata-2021-09-15-74995 (#20714) * CodeGen from PR 15874 in Azure/azure-rest-api-specs Adding 202 Accepted for deletion call (#15874) * Adding 202 for deletion call * Adding headers to suppress warnings * version,CHANGELOG Co-authored-by: SDKAuto <sdkautomation@microsoft.com> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> commit 0645f49 Author: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> Date: Thu Sep 16 15:58:10 2021 -0700 [Test Proxy] Make add_sanitizer a module-level method (#20701) commit ddf49b1 Author: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> Date: Thu Sep 16 15:27:08 2021 -0700 [Test proxy] Add migration guide (#20469) commit e116660 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Thu Sep 16 12:33:48 2021 -0700 Sync eng/common directory with azure-sdk-tools for PR 2011 (#20702) * Common pipeline template and script to detect API changes * Cahnges as per review comments * Review comment changes * CCahgnes as per review comments * Show warning for list of failed packages to detect API changes * Apply suggestions from code review Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: praveenkuttappan <prmarott@microsoft.com> Co-authored-by: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> commit 44e2acf Author: Scott Beddall <45376673+scbedd@users.noreply.github.com> Date: Thu Sep 16 10:57:23 2021 -0700 protobuf to handle python 2.7 issues (#20725) commit 81c6aa0 Author: Xiang Yan <xiangsjtu@gmail.com> Date: Thu Sep 16 08:33:08 2021 -0700 add troubleshoot doc (#20684) * add troubleshoot doc * fix typo * update * update * update * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: Charles Lowell <chlowe@microsoft.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: Charles Lowell <chlowe@microsoft.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: Charles Lowell <chlowe@microsoft.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: Charles Lowell <chlowe@microsoft.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: Charles Lowell <chlowe@microsoft.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: Charles Lowell <chlowe@microsoft.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: Charles Lowell <chlowe@microsoft.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: Charles Lowell <chlowe@microsoft.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: Charles Lowell <chlowe@microsoft.com> * Update Troubleshoot.md * update error log Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> Co-authored-by: Charles Lowell <chlowe@microsoft.com> commit 87e0f99 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Wed Sep 15 15:32:41 2021 -0700 Sync eng/common directory with azure-sdk-tools for PR 2016 (#20706) * Make ServiceName optional for verify-changelog In cases like go where we don't pass a service name having this default to "not-specified" breaks things so we should allow for ServiceName and/or ServiceDirectory to be empty. * Put quotes around the strings to allow for empty Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> commit c80e26e Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Wed Sep 15 12:45:42 2021 -0700 Sync eng/common directory with azure-sdk-tools for PR 2009 (#20672) * Skip PSModule caching in container jobs * Add succeeded check to condition Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> Co-authored-by: Ben Broderick Phillips <ben@benbp.net> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> commit 1efff7f Author: Travis Prescott <tjprescott@users.noreply.github.com> Date: Wed Sep 15 10:53:42 2021 -0700 [Search] Add skillset validation (#20669) * Add client-side validation and test. * Add skillset validation test. * Make code more Pythonic. commit 6a06b0e Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Tue Sep 14 16:56:19 2021 -0700 Add for multiple levels of Atx Headers in the CHANGELOG.md (#20694) Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> commit 3fdbaa7 Author: swathipil <76007337+swathipil@users.noreply.github.com> Date: Tue Sep 14 16:27:06 2021 -0700 [EventHub] update arm template with storage conn str (#20376) * update test resources * fix * fix failing tests * adams comments * pylint * remove dateutil * adams comments * nit commit 279e7eb Author: Rakshith Bhyravabhotla <sabhyrav@microsoft.com> Date: Tue Sep 14 15:22:05 2021 -0700 Add a new row type in query (#20685) * Add row type * Add a new row type * add test * lint * Apply suggestions from code review * changes commit 5016742 Author: luc <44377201+LuChen-Microsoft@users.noreply.github.com> Date: Tue Sep 14 13:09:43 2021 -0700 Update changelog date (#20686) * update swagger * update release date commit 080f88d Author: swathipil <76007337+swathipil@users.noreply.github.com> Date: Tue Sep 14 13:01:32 2021 -0700 [SchemaRegistry] update type of `schema` in `serialize` (#20683) * update type * update sample naming commit 599a099 Author: Rakshith Bhyravabhotla <sabhyrav@microsoft.com> Date: Tue Sep 14 09:41:19 2021 -0700 Handle Errors and Tables in Query (#20658) * initial commit * batch set * batch * tests + changes * more tests * lint * changelog * Apply suggestions from code review * comment * lint * querry * comments commit 3252969 Author: swathipil <76007337+swathipil@users.noreply.github.com> Date: Tue Sep 14 09:17:18 2021 -0700 [SchemaRegistry] remove codec param in serializer (#20671) * remove codec * changelog commit 27b7e75 Author: msyyc <70930885+msyyc@users.noreply.github.com> Date: Tue Sep 14 16:52:11 2021 +0800 Update change_log.py (#20680) commit fd80cb7 Author: Azure CLI Bot <azclibot@microsoft.com> Date: Tue Sep 14 13:52:13 2021 +0800 [AutoRelease] t2-storage-2021-09-14-45016(Do not merge) (#20678) * CodeGen from PR 15627 in Azure/azure-rest-api-specs [SRP] 2021-06-01 Swagger Api (#15627) * Add June21 Swagger Api version, Updated Readme files * adding abort and hnson migration swagger API * swagger: marking requesttype as required parameter for hns onmigration * Added new PublicNetworkAccess property to swagger spec * Add enableNfsV3RootSquash and enableNfsV3AllSquash to June21 swagger * Add Account Level VLW Swagger changes and example * Update Blob Inventory Api comment to include AccessTierInferred and Tags * Rename HnsOn to hierarchical namespace * [Swagger] [June21] Added defaultToOAuthAuthentication to swagger spec * Update Spell check custom words list. Correct incorrect spellings * Add missing refrences to PublicNetworkAccess Examples * Add required type:object, Add default return type for hns migration apis * Prettier tool update to storage.json * Add update account with immutability policy example * Removed StorageFileDataSmbShareOwner as Server side does not support it * Add AllowProtectedAppendWritesAll feature changes with example * Updated enum values and description for PublicNetworkAccess * Add type:object to ProtectedAppendWritesHistory ; Spellcheck * version,CHANGELOG Co-authored-by: SDKAuto <sdkautomation@microsoft.com> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> commit 3eb0af9 Author: William Harding <william.jeffrey.harding@gmail.com> Date: Mon Sep 13 16:06:06 2021 -0700 Updated notebooks to make them more "general" (#15660) * Updated notebooks to make them more "general" * updated gitignore, added models, updated path * reverted gitignore * reverting gitignore * Renamed some files, changed model id to be more generic commit 69be40d Author: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> Date: Mon Sep 13 15:35:26 2021 -0700 [Key Vault] Update new test resource script (#20663) commit ce307fe Author: Scott Addie <10702007+scottaddie@users.noreply.github.com> Date: Mon Sep 13 17:23:16 2021 -0500 Final consistency review of Monitor Query README (#20667) * Final consistency review of Monitor Query README * Add rate limits section commit c4d64b2 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Mon Sep 13 13:50:44 2021 -0700 Sync eng/common directory with azure-sdk-tools for PR 1979 (#20666) * Move logic for removing empty sections to ChangeLog-Operations.ps1 * Refactor sections regex * Add SanitizeEntry parameter Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> commit 3a537c9 Author: Travis Prescott <tjprescott@users.noreply.github.com> Date: Mon Sep 13 13:45:21 2021 -0700 Update docstrings for custom models. (#20592) commit 90ce516 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Mon Sep 13 13:06:02 2021 -0700 Fix SemVer.ToString to handle v0 case (#20665) Since we are treating v0 versions as prerelease we need to make sure we don't accidently start to add the bogus prerelease label in cases where we call ToString() on the version. Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> commit dd67039 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Mon Sep 13 13:04:52 2021 -0700 Sync eng/common directory with azure-sdk-tools for PR 1946 (#20656) * Add ability to exit gracefully when all files in the diff are excluded * Address case where cspell exits with an error when all files from the 'files' config list are excluded by the expressions in 'ignorePaths' * Add tests * Review feedback: impl goes at the bottom and should be treated as a script, logic for testing should happen above that and exit appropriately if running tests * Import common instead of logging * Enable strict mode Co-authored-by: Daniel Jurek <djurek@microsoft.com> commit 7b2aeaf Author: swathipil <76007337+swathipil@users.noreply.github.com> Date: Mon Sep 13 10:47:42 2021 -0700 [EventHubs] update test to test async producer (#19892) - call async Producer for testing/improving code coverage - remove passing in fake kwarg to PartitionContext; untested lines in PartitionContext can only be tested with a user implemented CheckpointStore class, so not worrying about this commit 8f28e2a Author: Leighton Chen <lechen@microsoft.com> Date: Mon Sep 13 10:37:18 2021 -0700 [Monitor exporter] Add OTLP and dual exporter scenario to samples (#20634) * rpc * samples commit 5450368 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Mon Sep 13 09:21:54 2021 -0700 Sync eng/common directory with azure-sdk-tools for PR 1983 (#20618) * Doc Updates and Revisions for External Use The focus of these changes is to revise the script to better support use by external contributors and others outside of the Azure SDK ecosystem and without access to the Microsoft AAD Tenant. Changes include: - Creation of a new Test Application service principal is now possible from a non-Microsoft AAD tenant. - When a new Test Application principal is created, the principle of least privilege is now applied; the new Test Application is granted ownership of the resource group associated with the test resources and no longer has access to any other resources in the subscription. - If an existing Test Application principal is specified, it will be assigned ownership of the resource group created. This supports using a Test Application principal without privileges at the subscription-level. - When no provisioner is specified, the script is now executed in the context of the caller rather than the Test Application principal. This supports using a Test Application principal that has restricted privileges and better aligns to the purpose of the Test Application principal. - The `$TestApplicationOid` is now explicitly bound at the time a new Test Application principal is created rather than having to query for it later. - Common error scenarios resulting from lack of permissions now provide messaging with more context of why the failure occurred and suggest remediation. - Added new examples to illustrate the common call patterns needed by external contributors running the script, outside of the Microsoft tenant and Azure SDK ecosystem. - Documentation has been enhanced with additional context to detail the permissions and roles assigned by the script. - Added documentation details for Bicep template use. * Add the provisioner OID to the deployment params Key Vault needs this to deploy Managed HSMs. There's a corresponding change necessary in test-resources.json I'll roll out across languages. * Fixing typos and spelling mistakes Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Co-authored-by: Heath Stewart <heaths@microsoft.com> commit b7b7e36 Author: Travis Prescott <tjprescott@users.noreply.github.com> Date: Mon Sep 13 09:10:38 2021 -0700 [Search] Update SearchClient.search API (#20602) * Update SearchClient.search API. * Update CHANGELOG and async SearchClient. * Update parameter parsing for omitted values. * Code review comments and linter fixes. commit 4048684 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Sun Sep 12 15:49:22 2021 -0700 Increment version for monitor releases (#20635) Increment package version after release of azure-monitor-query
commit 87e0f99 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Wed Sep 15 15:32:41 2021 -0700 Sync eng/common directory with azure-sdk-tools for PR 2016 (Azure#20706) * Make ServiceName optional for verify-changelog In cases like go where we don't pass a service name having this default to "not-specified" breaks things so we should allow for ServiceName and/or ServiceDirectory to be empty. * Put quotes around the strings to allow for empty Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> commit c80e26e Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Wed Sep 15 12:45:42 2021 -0700 Sync eng/common directory with azure-sdk-tools for PR 2009 (Azure#20672) * Skip PSModule caching in container jobs * Add succeeded check to condition Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> Co-authored-by: Ben Broderick Phillips <ben@benbp.net> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> commit 1efff7f Author: Travis Prescott <tjprescott@users.noreply.github.com> Date: Wed Sep 15 10:53:42 2021 -0700 [Search] Add skillset validation (Azure#20669) * Add client-side validation and test. * Add skillset validation test. * Make code more Pythonic. commit 6a06b0e Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Tue Sep 14 16:56:19 2021 -0700 Add for multiple levels of Atx Headers in the CHANGELOG.md (Azure#20694) Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> commit 3fdbaa7 Author: swathipil <76007337+swathipil@users.noreply.github.com> Date: Tue Sep 14 16:27:06 2021 -0700 [EventHub] update arm template with storage conn str (Azure#20376) * update test resources * fix * fix failing tests * adams comments * pylint * remove dateutil * adams comments * nit commit 279e7eb Author: Rakshith Bhyravabhotla <sabhyrav@microsoft.com> Date: Tue Sep 14 15:22:05 2021 -0700 Add a new row type in query (Azure#20685) * Add row type * Add a new row type * add test * lint * Apply suggestions from code review * changes commit 5016742 Author: luc <44377201+LuChen-Microsoft@users.noreply.github.com> Date: Tue Sep 14 13:09:43 2021 -0700 Update changelog date (Azure#20686) * update swagger * update release date commit 080f88d Author: swathipil <76007337+swathipil@users.noreply.github.com> Date: Tue Sep 14 13:01:32 2021 -0700 [SchemaRegistry] update type of `schema` in `serialize` (Azure#20683) * update type * update sample naming commit 599a099 Author: Rakshith Bhyravabhotla <sabhyrav@microsoft.com> Date: Tue Sep 14 09:41:19 2021 -0700 Handle Errors and Tables in Query (Azure#20658) * initial commit * batch set * batch * tests + changes * more tests * lint * changelog * Apply suggestions from code review * comment * lint * querry * comments commit 3252969 Author: swathipil <76007337+swathipil@users.noreply.github.com> Date: Tue Sep 14 09:17:18 2021 -0700 [SchemaRegistry] remove codec param in serializer (Azure#20671) * remove codec * changelog commit 27b7e75 Author: msyyc <70930885+msyyc@users.noreply.github.com> Date: Tue Sep 14 16:52:11 2021 +0800 Update change_log.py (Azure#20680) commit fd80cb7 Author: Azure CLI Bot <azclibot@microsoft.com> Date: Tue Sep 14 13:52:13 2021 +0800 [AutoRelease] t2-storage-2021-09-14-45016(Do not merge) (Azure#20678) * CodeGen from PR 15627 in Azure/azure-rest-api-specs [SRP] 2021-06-01 Swagger Api (Azure#15627) * Add June21 Swagger Api version, Updated Readme files * adding abort and hnson migration swagger API * swagger: marking requesttype as required parameter for hns onmigration * Added new PublicNetworkAccess property to swagger spec * Add enableNfsV3RootSquash and enableNfsV3AllSquash to June21 swagger * Add Account Level VLW Swagger changes and example * Update Blob Inventory Api comment to include AccessTierInferred and Tags * Rename HnsOn to hierarchical namespace * [Swagger] [June21] Added defaultToOAuthAuthentication to swagger spec * Update Spell check custom words list. Correct incorrect spellings * Add missing refrences to PublicNetworkAccess Examples * Add required type:object, Add default return type for hns migration apis * Prettier tool update to storage.json * Add update account with immutability policy example * Removed StorageFileDataSmbShareOwner as Server side does not support it * Add AllowProtectedAppendWritesAll feature changes with example * Updated enum values and description for PublicNetworkAccess * Add type:object to ProtectedAppendWritesHistory ; Spellcheck * version,CHANGELOG Co-authored-by: SDKAuto <sdkautomation@microsoft.com> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> commit 3eb0af9 Author: William Harding <william.jeffrey.harding@gmail.com> Date: Mon Sep 13 16:06:06 2021 -0700 Updated notebooks to make them more "general" (Azure#15660) * Updated notebooks to make them more "general" * updated gitignore, added models, updated path * reverted gitignore * reverting gitignore * Renamed some files, changed model id to be more generic commit 69be40d Author: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> Date: Mon Sep 13 15:35:26 2021 -0700 [Key Vault] Update new test resource script (Azure#20663) commit ce307fe Author: Scott Addie <10702007+scottaddie@users.noreply.github.com> Date: Mon Sep 13 17:23:16 2021 -0500 Final consistency review of Monitor Query README (Azure#20667) * Final consistency review of Monitor Query README * Add rate limits section commit c4d64b2 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Mon Sep 13 13:50:44 2021 -0700 Sync eng/common directory with azure-sdk-tools for PR 1979 (Azure#20666) * Move logic for removing empty sections to ChangeLog-Operations.ps1 * Refactor sections regex * Add SanitizeEntry parameter Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> commit 3a537c9 Author: Travis Prescott <tjprescott@users.noreply.github.com> Date: Mon Sep 13 13:45:21 2021 -0700 Update docstrings for custom models. (Azure#20592) commit 90ce516 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Mon Sep 13 13:06:02 2021 -0700 Fix SemVer.ToString to handle v0 case (Azure#20665) Since we are treating v0 versions as prerelease we need to make sure we don't accidently start to add the bogus prerelease label in cases where we call ToString() on the version. Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> commit dd67039 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Mon Sep 13 13:04:52 2021 -0700 Sync eng/common directory with azure-sdk-tools for PR 1946 (Azure#20656) * Add ability to exit gracefully when all files in the diff are excluded * Address case where cspell exits with an error when all files from the 'files' config list are excluded by the expressions in 'ignorePaths' * Add tests * Review feedback: impl goes at the bottom and should be treated as a script, logic for testing should happen above that and exit appropriately if running tests * Import common instead of logging * Enable strict mode Co-authored-by: Daniel Jurek <djurek@microsoft.com> commit 7b2aeaf Author: swathipil <76007337+swathipil@users.noreply.github.com> Date: Mon Sep 13 10:47:42 2021 -0700 [EventHubs] update test to test async producer (Azure#19892) - call async Producer for testing/improving code coverage - remove passing in fake kwarg to PartitionContext; untested lines in PartitionContext can only be tested with a user implemented CheckpointStore class, so not worrying about this commit 8f28e2a Author: Leighton Chen <lechen@microsoft.com> Date: Mon Sep 13 10:37:18 2021 -0700 [Monitor exporter] Add OTLP and dual exporter scenario to samples (Azure#20634) * rpc * samples commit 5450368 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Mon Sep 13 09:21:54 2021 -0700 Sync eng/common directory with azure-sdk-tools for PR 1983 (Azure#20618) * Doc Updates and Revisions for External Use The focus of these changes is to revise the script to better support use by external contributors and others outside of the Azure SDK ecosystem and without access to the Microsoft AAD Tenant. Changes include: - Creation of a new Test Application service principal is now possible from a non-Microsoft AAD tenant. - When a new Test Application principal is created, the principle of least privilege is now applied; the new Test Application is granted ownership of the resource group associated with the test resources and no longer has access to any other resources in the subscription. - If an existing Test Application principal is specified, it will be assigned ownership of the resource group created. This supports using a Test Application principal without privileges at the subscription-level. - When no provisioner is specified, the script is now executed in the context of the caller rather than the Test Application principal. This supports using a Test Application principal that has restricted privileges and better aligns to the purpose of the Test Application principal. - The `$TestApplicationOid` is now explicitly bound at the time a new Test Application principal is created rather than having to query for it later. - Common error scenarios resulting from lack of permissions now provide messaging with more context of why the failure occurred and suggest remediation. - Added new examples to illustrate the common call patterns needed by external contributors running the script, outside of the Microsoft tenant and Azure SDK ecosystem. - Documentation has been enhanced with additional context to detail the permissions and roles assigned by the script. - Added documentation details for Bicep template use. * Add the provisioner OID to the deployment params Key Vault needs this to deploy Managed HSMs. There's a corresponding change necessary in test-resources.json I'll roll out across languages. * Fixing typos and spelling mistakes Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Co-authored-by: Heath Stewart <heaths@microsoft.com> commit b7b7e36 Author: Travis Prescott <tjprescott@users.noreply.github.com> Date: Mon Sep 13 09:10:38 2021 -0700 [Search] Update SearchClient.search API (Azure#20602) * Update SearchClient.search API. * Update CHANGELOG and async SearchClient. * Update parameter parsing for omitted values. * Code review comments and linter fixes. commit 4048684 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Sun Sep 12 15:49:22 2021 -0700 Increment version for monitor releases (Azure#20635) Increment package version after release of azure-monitor-query
commit 7832c5a Author: Azure CLI Bot <azclibot@microsoft.com> Date: Sat Sep 18 09:34:11 2021 +0800 [AutoRelease] t2-eventhub-2021-09-17-55263(Do not merge) (Azure#20739) * CodeGen from PR 15979 in Azure/azure-rest-api-specs EventHub: Added missing Cluster API in 2021-06-01-preview (Azure#15979) * Added missing Cluster APIs to 2021-01-01-preview * added cluster API in 2021-06-01-preview * updated lint errors * update 1 * added listbysubscription * fixed ModelValidation Co-authored-by: v-ajnava <v-ajnava@microsoft.com> * version,CHANGELOG Co-authored-by: SDKAuto <sdkautomation@microsoft.com> Co-authored-by: v-ajnava <v-ajnava@microsoft.com> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> commit 29d98e8 Author: Chidozie Ononiwu (His Righteousness) <31145988+chidozieononiwu@users.noreply.github.com> Date: Fri Sep 17 17:27:57 2021 -0700 Fix broken link in python repo (Azure#20746) commit cbfacbd Author: Xiaoxi Fu <49707495+xiafu-msft@users.noreply.github.com> Date: Fri Sep 17 14:04:28 2021 -0700 [Storage]Unify service version and update changelog (Azure#20723) * [Storage]Unify service version and update changelog * fix test commit ea5ecea Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Fri Sep 17 10:19:31 2021 -0700 Sync eng/common directory with azure-sdk-tools for PR 2010 (Azure#20729) * Remove empty sections in changelog entry as part of prepare release * Update SECTIONS_HEADER_REGEX to accomodate various header levels Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> commit 9b63801 Author: Azure CLI Bot <azclibot@microsoft.com> Date: Fri Sep 17 15:00:44 2021 +0800 [AutoRelease] t2-azurearcdata-2021-09-15-74995 (Azure#20714) * CodeGen from PR 15874 in Azure/azure-rest-api-specs Adding 202 Accepted for deletion call (Azure#15874) * Adding 202 for deletion call * Adding headers to suppress warnings * version,CHANGELOG Co-authored-by: SDKAuto <sdkautomation@microsoft.com> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> commit 0645f49 Author: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> Date: Thu Sep 16 15:58:10 2021 -0700 [Test Proxy] Make add_sanitizer a module-level method (Azure#20701) commit ddf49b1 Author: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> Date: Thu Sep 16 15:27:08 2021 -0700 [Test proxy] Add migration guide (Azure#20469) commit e116660 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Thu Sep 16 12:33:48 2021 -0700 Sync eng/common directory with azure-sdk-tools for PR 2011 (Azure#20702) * Common pipeline template and script to detect API changes * Cahnges as per review comments * Review comment changes * CCahgnes as per review comments * Show warning for list of failed packages to detect API changes * Apply suggestions from code review Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: praveenkuttappan <prmarott@microsoft.com> Co-authored-by: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> commit 44e2acf Author: Scott Beddall <45376673+scbedd@users.noreply.github.com> Date: Thu Sep 16 10:57:23 2021 -0700 protobuf to handle python 2.7 issues (Azure#20725) commit 81c6aa0 Author: Xiang Yan <xiangsjtu@gmail.com> Date: Thu Sep 16 08:33:08 2021 -0700 add troubleshoot doc (Azure#20684) * add troubleshoot doc * fix typo * update * update * update * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: Charles Lowell <chlowe@microsoft.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: Charles Lowell <chlowe@microsoft.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: Charles Lowell <chlowe@microsoft.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: Charles Lowell <chlowe@microsoft.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: Charles Lowell <chlowe@microsoft.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: Charles Lowell <chlowe@microsoft.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: Charles Lowell <chlowe@microsoft.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: Charles Lowell <chlowe@microsoft.com> * Update sdk/identity/azure-identity/Troubleshoot.md Co-authored-by: Charles Lowell <chlowe@microsoft.com> * Update Troubleshoot.md * update error log Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> Co-authored-by: Charles Lowell <chlowe@microsoft.com> commit 87e0f99 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Wed Sep 15 15:32:41 2021 -0700 Sync eng/common directory with azure-sdk-tools for PR 2016 (Azure#20706) * Make ServiceName optional for verify-changelog In cases like go where we don't pass a service name having this default to "not-specified" breaks things so we should allow for ServiceName and/or ServiceDirectory to be empty. * Put quotes around the strings to allow for empty Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> commit c80e26e Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Wed Sep 15 12:45:42 2021 -0700 Sync eng/common directory with azure-sdk-tools for PR 2009 (Azure#20672) * Skip PSModule caching in container jobs * Add succeeded check to condition Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> Co-authored-by: Ben Broderick Phillips <ben@benbp.net> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> commit 1efff7f Author: Travis Prescott <tjprescott@users.noreply.github.com> Date: Wed Sep 15 10:53:42 2021 -0700 [Search] Add skillset validation (Azure#20669) * Add client-side validation and test. * Add skillset validation test. * Make code more Pythonic. commit 6a06b0e Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Tue Sep 14 16:56:19 2021 -0700 Add for multiple levels of Atx Headers in the CHANGELOG.md (Azure#20694) Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> commit 3fdbaa7 Author: swathipil <76007337+swathipil@users.noreply.github.com> Date: Tue Sep 14 16:27:06 2021 -0700 [EventHub] update arm template with storage conn str (Azure#20376) * update test resources * fix * fix failing tests * adams comments * pylint * remove dateutil * adams comments * nit commit 279e7eb Author: Rakshith Bhyravabhotla <sabhyrav@microsoft.com> Date: Tue Sep 14 15:22:05 2021 -0700 Add a new row type in query (Azure#20685) * Add row type * Add a new row type * add test * lint * Apply suggestions from code review * changes commit 5016742 Author: luc <44377201+LuChen-Microsoft@users.noreply.github.com> Date: Tue Sep 14 13:09:43 2021 -0700 Update changelog date (Azure#20686) * update swagger * update release date commit 080f88d Author: swathipil <76007337+swathipil@users.noreply.github.com> Date: Tue Sep 14 13:01:32 2021 -0700 [SchemaRegistry] update type of `schema` in `serialize` (Azure#20683) * update type * update sample naming commit 599a099 Author: Rakshith Bhyravabhotla <sabhyrav@microsoft.com> Date: Tue Sep 14 09:41:19 2021 -0700 Handle Errors and Tables in Query (Azure#20658) * initial commit * batch set * batch * tests + changes * more tests * lint * changelog * Apply suggestions from code review * comment * lint * querry * comments commit 3252969 Author: swathipil <76007337+swathipil@users.noreply.github.com> Date: Tue Sep 14 09:17:18 2021 -0700 [SchemaRegistry] remove codec param in serializer (Azure#20671) * remove codec * changelog commit 27b7e75 Author: msyyc <70930885+msyyc@users.noreply.github.com> Date: Tue Sep 14 16:52:11 2021 +0800 Update change_log.py (Azure#20680) commit fd80cb7 Author: Azure CLI Bot <azclibot@microsoft.com> Date: Tue Sep 14 13:52:13 2021 +0800 [AutoRelease] t2-storage-2021-09-14-45016(Do not merge) (Azure#20678) * CodeGen from PR 15627 in Azure/azure-rest-api-specs [SRP] 2021-06-01 Swagger Api (Azure#15627) * Add June21 Swagger Api version, Updated Readme files * adding abort and hnson migration swagger API * swagger: marking requesttype as required parameter for hns onmigration * Added new PublicNetworkAccess property to swagger spec * Add enableNfsV3RootSquash and enableNfsV3AllSquash to June21 swagger * Add Account Level VLW Swagger changes and example * Update Blob Inventory Api comment to include AccessTierInferred and Tags * Rename HnsOn to hierarchical namespace * [Swagger] [June21] Added defaultToOAuthAuthentication to swagger spec * Update Spell check custom words list. Correct incorrect spellings * Add missing refrences to PublicNetworkAccess Examples * Add required type:object, Add default return type for hns migration apis * Prettier tool update to storage.json * Add update account with immutability policy example * Removed StorageFileDataSmbShareOwner as Server side does not support it * Add AllowProtectedAppendWritesAll feature changes with example * Updated enum values and description for PublicNetworkAccess * Add type:object to ProtectedAppendWritesHistory ; Spellcheck * version,CHANGELOG Co-authored-by: SDKAuto <sdkautomation@microsoft.com> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> commit 3eb0af9 Author: William Harding <william.jeffrey.harding@gmail.com> Date: Mon Sep 13 16:06:06 2021 -0700 Updated notebooks to make them more "general" (Azure#15660) * Updated notebooks to make them more "general" * updated gitignore, added models, updated path * reverted gitignore * reverting gitignore * Renamed some files, changed model id to be more generic commit 69be40d Author: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> Date: Mon Sep 13 15:35:26 2021 -0700 [Key Vault] Update new test resource script (Azure#20663) commit ce307fe Author: Scott Addie <10702007+scottaddie@users.noreply.github.com> Date: Mon Sep 13 17:23:16 2021 -0500 Final consistency review of Monitor Query README (Azure#20667) * Final consistency review of Monitor Query README * Add rate limits section commit c4d64b2 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Mon Sep 13 13:50:44 2021 -0700 Sync eng/common directory with azure-sdk-tools for PR 1979 (Azure#20666) * Move logic for removing empty sections to ChangeLog-Operations.ps1 * Refactor sections regex * Add SanitizeEntry parameter Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> commit 3a537c9 Author: Travis Prescott <tjprescott@users.noreply.github.com> Date: Mon Sep 13 13:45:21 2021 -0700 Update docstrings for custom models. (Azure#20592) commit 90ce516 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Mon Sep 13 13:06:02 2021 -0700 Fix SemVer.ToString to handle v0 case (Azure#20665) Since we are treating v0 versions as prerelease we need to make sure we don't accidently start to add the bogus prerelease label in cases where we call ToString() on the version. Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> commit dd67039 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Mon Sep 13 13:04:52 2021 -0700 Sync eng/common directory with azure-sdk-tools for PR 1946 (Azure#20656) * Add ability to exit gracefully when all files in the diff are excluded * Address case where cspell exits with an error when all files from the 'files' config list are excluded by the expressions in 'ignorePaths' * Add tests * Review feedback: impl goes at the bottom and should be treated as a script, logic for testing should happen above that and exit appropriately if running tests * Import common instead of logging * Enable strict mode Co-authored-by: Daniel Jurek <djurek@microsoft.com> commit 7b2aeaf Author: swathipil <76007337+swathipil@users.noreply.github.com> Date: Mon Sep 13 10:47:42 2021 -0700 [EventHubs] update test to test async producer (Azure#19892) - call async Producer for testing/improving code coverage - remove passing in fake kwarg to PartitionContext; untested lines in PartitionContext can only be tested with a user implemented CheckpointStore class, so not worrying about this commit 8f28e2a Author: Leighton Chen <lechen@microsoft.com> Date: Mon Sep 13 10:37:18 2021 -0700 [Monitor exporter] Add OTLP and dual exporter scenario to samples (Azure#20634) * rpc * samples commit 5450368 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Mon Sep 13 09:21:54 2021 -0700 Sync eng/common directory with azure-sdk-tools for PR 1983 (Azure#20618) * Doc Updates and Revisions for External Use The focus of these changes is to revise the script to better support use by external contributors and others outside of the Azure SDK ecosystem and without access to the Microsoft AAD Tenant. Changes include: - Creation of a new Test Application service principal is now possible from a non-Microsoft AAD tenant. - When a new Test Application principal is created, the principle of least privilege is now applied; the new Test Application is granted ownership of the resource group associated with the test resources and no longer has access to any other resources in the subscription. - If an existing Test Application principal is specified, it will be assigned ownership of the resource group created. This supports using a Test Application principal without privileges at the subscription-level. - When no provisioner is specified, the script is now executed in the context of the caller rather than the Test Application principal. This supports using a Test Application principal that has restricted privileges and better aligns to the purpose of the Test Application principal. - The `$TestApplicationOid` is now explicitly bound at the time a new Test Application principal is created rather than having to query for it later. - Common error scenarios resulting from lack of permissions now provide messaging with more context of why the failure occurred and suggest remediation. - Added new examples to illustrate the common call patterns needed by external contributors running the script, outside of the Microsoft tenant and Azure SDK ecosystem. - Documentation has been enhanced with additional context to detail the permissions and roles assigned by the script. - Added documentation details for Bicep template use. * Add the provisioner OID to the deployment params Key Vault needs this to deploy Managed HSMs. There's a corresponding change necessary in test-resources.json I'll roll out across languages. * Fixing typos and spelling mistakes Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Co-authored-by: Heath Stewart <heaths@microsoft.com> commit b7b7e36 Author: Travis Prescott <tjprescott@users.noreply.github.com> Date: Mon Sep 13 09:10:38 2021 -0700 [Search] Update SearchClient.search API (Azure#20602) * Update SearchClient.search API. * Update CHANGELOG and async SearchClient. * Update parameter parsing for omitted values. * Code review comments and linter fixes. commit 4048684 Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Sun Sep 12 15:49:22 2021 -0700 Increment version for monitor releases (Azure#20635) Increment package version after release of azure-monitor-query
* initial commit * batch set * batch * tests + changes * more tests * lint * changelog * Apply suggestions from code review * comment * lint * querry * comments
* initial commit * batch set * batch * tests + changes * more tests * lint * changelog * Apply suggestions from code review * comment * lint * querry * comments
* initial commit * batch set * batch * tests + changes * more tests * lint * changelog * Apply suggestions from code review * comment * lint * querry * comments
Merge Microsoft.app 2022 06 01 preview to main (Azure#20787) * Adds base for updating Microsoft.App from version stable/2022-03-01 to version 2022-05-01 * Updates readme * Updates API version in new specs and examples * Add app diag to 2022-05-01 (Azure#18678) * Add container apps diagnostics * Fix validation errors * Move Microsoft.App diag APIs to 2022-05-01 * Fix validation errors * Fix validation errors * Fix validation errors 3 * Change operationIds Co-authored-by: Michimune Kohno <mikono@microsoft.com> * Fix definition for customhostnameesult (Azure#19014) * fix * update * more fix * Cherry pick for the parameter name fixes for the 2022-03-01 and making the same fixes in 2022-05-01 (Azure#19048) * Correct Probe enums (Azure#18839) * fix probe enums * Fix revision mode enum * Fix patch example * Fix the casing of enums in the latest api version * Change the parameter names to unblock Terraform release (Azure#19005) * contianerapps: fixing swagger inconsistencies in 2022-01-01-preview * containerapps: fixing inconsistencies in the 2022-03-01 swagger * containerapps: updating the examples for 2022-01-01-preview * containerapps: updating the examples to account for the updated parameter names * containerapps: fixing linting * fix probe enums * Fix revision mode enum * Fix the policheck error * Revert "containerapps: fixing linting" This reverts commit 3c4872f4a43fbe1a285830461f48d8c0a5ffeee8. * Revert "containerapps: updating the examples for 2022-01-01-preview" This reverts commit 9b81fbd65652d558c0296d72a63ca1a7c4850e3c. * Revert "contianerapps: fixing swagger inconsistencies in 2022-01-01-preview" This reverts commit 553fc551b3239598157238ed6246085748421b87. * Undo changes to 2022-01-01-preview * Fix one issue * fix remaining inconsistency * fix authConfig and sourceControl names Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu> Co-authored-by: Mike Vu <mikevu@microsoft.com> * Change param names * Fix examples * Fix CI errors Co-authored-by: Mike Vu <mikevu@microsoft.com> Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu> * Fix description in all API versions (Azure#19313) * Fix description for ManagedEnvironment.Internal property (Azure#19307) * Fix descriptions in all api versions * Add traffic info to revisions api (Azure#19054) * Add traffic info to a revision api * Add deprecated prop * Prettier fixes * 1pdate based on new proposal * Rename * Change names * minor fix * Add httpReadBufferSize to dapr config in Microsoft.App-2022-05-01 (Azure#19360) * Add httpReadBufferSize to dapr config * remove nullable * Adds base for updating Microsoft.App from version stable/2022-05-01 to version 2022-06-01-preview * Updates readme * Updates API version in new specs and examples * Add new resources for 2022-06-01-preview (Azure#19494) * update * update * update * fix * update * update * update * update * fix * update * update * Enable Dapr AI Connection string for Microsoft.App connected environment (Azure#19974) * Enable Dapr AI Connection string for Microsoft.App connected environment * Fix dapr ai connection string * remove read * remove read permission of dapr ai connection string and instrument key for managed environment * fixes for comments * update (Azure#20013) * Fixdescriptions on microsoft.app 2022 06 01 preview (Azure#20133) * Fix casing for detector properties * Fix descriptions * Fix descriptions and detectorProperties in 2022-06-01-preview * Added `secretsStoreComponent` in 2022-06-01 spec (Azure#20044) * Added `secretsStoreComponent` in 2022-06-01 spec Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com> * Fixed typos and added example of name/key Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com> * Add custom domain configuration for managed environment (Azure#20149) Co-authored-by: Mengjun Qin <menqin@microsoft.com> * Add additional Dapr options (2022-06-01-preview) (Azure#19886) * Add additional Dapr options * Update examples for 2022-06-01-preview * force ci * force ci * force ci * adding ip-restriction feat (Azure#19841) * adding ip-restriction feat * remove from stable, add to preview * fix lintDiff error * fix modelvalidation error * fix formatting changes * rename names, add note to all allow or all deny * fix spell check error * update name and examples * rename `ipAddress` to `ipAddressRange` * making small change to re-run build pipeline * trigger GitHub actions * resolve comments Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com> * Remove Traffic Labels from revisions because they haven't been impelemented (Azure#20261) * Revert "Add traffic info to revisions api (Azure#19054)" This reverts commit 056cc51226bf2eef3d3a7e7bdca875a4a571026b. * Remove traffic labels from revisions * Add property for tcp apps (Azure#20193) * Add property for tcp apps * Add scale * Fix * Fix * Add Init Containers to common definitions (Azure#19855) * add init containers to common definitions * move changes to 06-01 preview * remove repeated container definition * fix allof syntax * fix anonymous container definition * fix lintdiff errors * fix container allof syntax * add more init examples * split baseContainer definition * remove description Co-authored-by: p-bouchon <pbouchon@microsoft.com> * Update container app provisioningstate (Azure#20411) * update * update * add property: maxInactiveRevisions (Azure#20334) * add property: maxInactiveRevisions * update * update * Add premium sku related properties for managed environment (Azure#19770) * Add premium sku related properties for managed environment * Move sku to base property * Add workloadProfileType * Examples for managed environment * Add container app example * Fix workloadProfiles * Add custom word * Fix WorkloadProfileType references * prettier fixes * Fix workload profile * Fix typo * remove readonly property for workload profile * Add object type * nit: Fix description location * Fix XmsIdentifierValidation * Remove spaces from enum values * Remove unwanted change * Add aka ms url * Update examples for workload profile type * Fix rebase issue * Fix json * Update description and move location * Remove provisioning state for node pool * sku capacity explanation * Remove capacity attribute * Remove capacity attribute from required * Mark sku property as required * Add x-ms-identifiers * Rename mimum and maximum * Rename skutype to skuName * Make sku property as optional * Make workload profile type as string * fix go SDK automation config Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn> * Fix source control status code in 2022-06-01-preview. (Azure#20429) * Remove 20220501 because we will not support it in server side (Azure#20427) * remove * update * Added support for user defined routing (Azure#20464) * Added support for user defined routing * Added examples * fixed JSON syntax * syntax fix * fixed vnetenvironment syntax * fixed camel case * case fix * enum syntax * fixed comma cases ManagedEnvironmentOutBoundType * fixing casing * Some more APIs (Azure#20448) * new APIs to 06-01 * test fix * more fixes * add last active time for revision (Azure#20658) * Add custom domain for connected env (Azure#20731) * add custom domain * fhcekout * billingMeters - GET endpoint (Azure#20485) * Swagger documentation for /locations/{location}/billingMeters - GET endpoint * Add example, fix validation errors * Fix ARM validation errors, code review comments * Fix response validation * add proxy resource properties * Response formatting * add default error response * ARM Review feedback + small naming change for a property * Change GB to GiB * Fix 2022-06-01-preview branch merge conflicts (Azure#20773) * Reset * more fixes * More fixes * another conflict fix * Fix old preview version * fix 2022-03-01 * supress lint Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com> Co-authored-by: Ruslan Yakushev <1664475+ruslany@users.noreply.github.com> Co-authored-by: michimune <michimune@outlook.com> Co-authored-by: Michimune Kohno <mikono@microsoft.com> Co-authored-by: Mike Vu <mikevu@microsoft.com> Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu> Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com> Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com> Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com> Co-authored-by: Mengjun Qin <767524684@qq.com> Co-authored-by: Mengjun Qin <menqin@microsoft.com> Co-authored-by: Taher Daroly <41846928+tdaroly@users.noreply.github.com> Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com> Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com> Co-authored-by: p-bouchon <107427816+p-bouchon@users.noreply.github.com> Co-authored-by: p-bouchon <pbouchon@microsoft.com> Co-authored-by: njucz <740360112@qq.com> Co-authored-by: JJ <jijohn@microsoft.com> Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn> Co-authored-by: yalixiang <88011184+yalixiang@users.noreply.github.com> Co-authored-by: Mahmoud Desokey <desokey@yahoo.com> Co-authored-by: Xingjian Wang <79332479+xwang971@users.noreply.github.com> Co-authored-by: trajkobal <108365738+trajkobal@users.noreply.github.com>
Rename Post Action and Add Secrets Tags (Azure#20775) * Adds base for updating Microsoft.App from version stable/2022-03-01 to version 2022-05-01 * Updates readme * Updates API version in new specs and examples * Add app diag to 2022-05-01 (Azure#18678) * Add container apps diagnostics * Fix validation errors * Move Microsoft.App diag APIs to 2022-05-01 * Fix validation errors * Fix validation errors * Fix validation errors 3 * Change operationIds Co-authored-by: Michimune Kohno <mikono@microsoft.com> * Fix definition for customhostnameesult (Azure#19014) * fix * update * more fix * Cherry pick for the parameter name fixes for the 2022-03-01 and making the same fixes in 2022-05-01 (Azure#19048) * Correct Probe enums (Azure#18839) * fix probe enums * Fix revision mode enum * Fix patch example * Fix the casing of enums in the latest api version * Change the parameter names to unblock Terraform release (Azure#19005) * contianerapps: fixing swagger inconsistencies in 2022-01-01-preview * containerapps: fixing inconsistencies in the 2022-03-01 swagger * containerapps: updating the examples for 2022-01-01-preview * containerapps: updating the examples to account for the updated parameter names * containerapps: fixing linting * fix probe enums * Fix revision mode enum * Fix the policheck error * Revert "containerapps: fixing linting" This reverts commit 3c4872f4a43fbe1a285830461f48d8c0a5ffeee8. * Revert "containerapps: updating the examples for 2022-01-01-preview" This reverts commit 9b81fbd65652d558c0296d72a63ca1a7c4850e3c. * Revert "contianerapps: fixing swagger inconsistencies in 2022-01-01-preview" This reverts commit 553fc551b3239598157238ed6246085748421b87. * Undo changes to 2022-01-01-preview * Fix one issue * fix remaining inconsistency * fix authConfig and sourceControl names Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu> Co-authored-by: Mike Vu <mikevu@microsoft.com> * Change param names * Fix examples * Fix CI errors Co-authored-by: Mike Vu <mikevu@microsoft.com> Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu> * Fix description in all API versions (Azure#19313) * Fix description for ManagedEnvironment.Internal property (Azure#19307) * Fix descriptions in all api versions * Add traffic info to revisions api (Azure#19054) * Add traffic info to a revision api * Add deprecated prop * Prettier fixes * 1pdate based on new proposal * Rename * Change names * minor fix * Add httpReadBufferSize to dapr config in Microsoft.App-2022-05-01 (Azure#19360) * Add httpReadBufferSize to dapr config * remove nullable * Adds base for updating Microsoft.App from version stable/2022-05-01 to version 2022-06-01-preview * Updates readme * Updates API version in new specs and examples * Add new resources for 2022-06-01-preview (Azure#19494) * update * update * update * fix * update * update * update * update * fix * update * update * Enable Dapr AI Connection string for Microsoft.App connected environment (Azure#19974) * Enable Dapr AI Connection string for Microsoft.App connected environment * Fix dapr ai connection string * remove read * remove read permission of dapr ai connection string and instrument key for managed environment * fixes for comments * update (Azure#20013) * Fixdescriptions on microsoft.app 2022 06 01 preview (Azure#20133) * Fix casing for detector properties * Fix descriptions * Fix descriptions and detectorProperties in 2022-06-01-preview * Added `secretsStoreComponent` in 2022-06-01 spec (Azure#20044) * Added `secretsStoreComponent` in 2022-06-01 spec Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com> * Fixed typos and added example of name/key Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com> * Add custom domain configuration for managed environment (Azure#20149) Co-authored-by: Mengjun Qin <menqin@microsoft.com> * Add additional Dapr options (2022-06-01-preview) (Azure#19886) * Add additional Dapr options * Update examples for 2022-06-01-preview * force ci * force ci * force ci * adding ip-restriction feat (Azure#19841) * adding ip-restriction feat * remove from stable, add to preview * fix lintDiff error * fix modelvalidation error * fix formatting changes * rename names, add note to all allow or all deny * fix spell check error * update name and examples * rename `ipAddress` to `ipAddressRange` * making small change to re-run build pipeline * trigger GitHub actions * resolve comments Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com> * Remove Traffic Labels from revisions because they haven't been impelemented (Azure#20261) * Revert "Add traffic info to revisions api (Azure#19054)" This reverts commit 056cc51226bf2eef3d3a7e7bdca875a4a571026b. * Remove traffic labels from revisions * Add property for tcp apps (Azure#20193) * Add property for tcp apps * Add scale * Fix * Fix * Add Init Containers to common definitions (Azure#19855) * add init containers to common definitions * move changes to 06-01 preview * remove repeated container definition * fix allof syntax * fix anonymous container definition * fix lintdiff errors * fix container allof syntax * add more init examples * split baseContainer definition * remove description Co-authored-by: p-bouchon <pbouchon@microsoft.com> * Update container app provisioningstate (Azure#20411) * update * update * add property: maxInactiveRevisions (Azure#20334) * add property: maxInactiveRevisions * update * update * Add premium sku related properties for managed environment (Azure#19770) * Add premium sku related properties for managed environment * Move sku to base property * Add workloadProfileType * Examples for managed environment * Add container app example * Fix workloadProfiles * Add custom word * Fix WorkloadProfileType references * prettier fixes * Fix workload profile * Fix typo * remove readonly property for workload profile * Add object type * nit: Fix description location * Fix XmsIdentifierValidation * Remove spaces from enum values * Remove unwanted change * Add aka ms url * Update examples for workload profile type * Fix rebase issue * Fix json * Update description and move location * Remove provisioning state for node pool * sku capacity explanation * Remove capacity attribute * Remove capacity attribute from required * Mark sku property as required * Add x-ms-identifiers * Rename mimum and maximum * Rename skutype to skuName * Make sku property as optional * Make workload profile type as string * fix go SDK automation config Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn> * Fix source control status code in 2022-06-01-preview. (Azure#20429) * Remove 20220501 because we will not support it in server side (Azure#20427) * remove * update * Added support for user defined routing (Azure#20464) * Added support for user defined routing * Added examples * fixed JSON syntax * syntax fix * fixed vnetenvironment syntax * fixed camel case * case fix * enum syntax * fixed comma cases ManagedEnvironmentOutBoundType * fixing casing * Some more APIs (Azure#20448) * new APIs to 06-01 * test fix * more fixes * add last active time for revision (Azure#20658) * Add custom domain for connected env (Azure#20731) * add custom domain * fhcekout * billingMeters - GET endpoint (Azure#20485) * Swagger documentation for /locations/{location}/billingMeters - GET endpoint * Add example, fix validation errors * Fix ARM validation errors, code review comments * Fix response validation * add proxy resource properties * Response formatting * add default error response * ARM Review feedback + small naming change for a property * Change GB to GiB * Rename Action * secrets tag * missed fix Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com> Co-authored-by: Ruslan Yakushev <1664475+ruslany@users.noreply.github.com> Co-authored-by: michimune <michimune@outlook.com> Co-authored-by: Michimune Kohno <mikono@microsoft.com> Co-authored-by: Zunli Hu <zuh@microsoft.com> Co-authored-by: Mike Vu <mikevu@microsoft.com> Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu> Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com> Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com> Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com> Co-authored-by: Mengjun Qin <767524684@qq.com> Co-authored-by: Mengjun Qin <menqin@microsoft.com> Co-authored-by: Taher Daroly <41846928+tdaroly@users.noreply.github.com> Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com> Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com> Co-authored-by: p-bouchon <107427816+p-bouchon@users.noreply.github.com> Co-authored-by: p-bouchon <pbouchon@microsoft.com> Co-authored-by: njucz <740360112@qq.com> Co-authored-by: JJ <jijohn@microsoft.com> Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn> Co-authored-by: yalixiang <88011184+yalixiang@users.noreply.github.com> Co-authored-by: Mahmoud Desokey <desokey@yahoo.com> Co-authored-by: trajkobal <108365738+trajkobal@users.noreply.github.com>
Availableworkloadprofiles - GET endpoint (Azure#20650) * Adds base for updating Microsoft.App from version stable/2022-03-01 to version 2022-05-01 * Updates readme * Updates API version in new specs and examples * Add app diag to 2022-05-01 (Azure#18678) * Add container apps diagnostics * Fix validation errors * Move Microsoft.App diag APIs to 2022-05-01 * Fix validation errors * Fix validation errors * Fix validation errors 3 * Change operationIds Co-authored-by: Michimune Kohno <mikono@microsoft.com> * Fix definition for customhostnameesult (Azure#19014) * fix * update * more fix * Cherry pick for the parameter name fixes for the 2022-03-01 and making the same fixes in 2022-05-01 (Azure#19048) * Correct Probe enums (Azure#18839) * fix probe enums * Fix revision mode enum * Fix patch example * Fix the casing of enums in the latest api version * Change the parameter names to unblock Terraform release (Azure#19005) * contianerapps: fixing swagger inconsistencies in 2022-01-01-preview * containerapps: fixing inconsistencies in the 2022-03-01 swagger * containerapps: updating the examples for 2022-01-01-preview * containerapps: updating the examples to account for the updated parameter names * containerapps: fixing linting * fix probe enums * Fix revision mode enum * Fix the policheck error * Revert "containerapps: fixing linting" This reverts commit 3c4872f4a43fbe1a285830461f48d8c0a5ffeee8. * Revert "containerapps: updating the examples for 2022-01-01-preview" This reverts commit 9b81fbd65652d558c0296d72a63ca1a7c4850e3c. * Revert "contianerapps: fixing swagger inconsistencies in 2022-01-01-preview" This reverts commit 553fc551b3239598157238ed6246085748421b87. * Undo changes to 2022-01-01-preview * Fix one issue * fix remaining inconsistency * fix authConfig and sourceControl names Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu> Co-authored-by: Mike Vu <mikevu@microsoft.com> * Change param names * Fix examples * Fix CI errors Co-authored-by: Mike Vu <mikevu@microsoft.com> Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu> * Fix description in all API versions (Azure#19313) * Fix description for ManagedEnvironment.Internal property (Azure#19307) * Fix descriptions in all api versions * Add traffic info to revisions api (Azure#19054) * Add traffic info to a revision api * Add deprecated prop * Prettier fixes * 1pdate based on new proposal * Rename * Change names * minor fix * Add httpReadBufferSize to dapr config in Microsoft.App-2022-05-01 (Azure#19360) * Add httpReadBufferSize to dapr config * remove nullable * Adds base for updating Microsoft.App from version stable/2022-05-01 to version 2022-06-01-preview * Updates readme * Updates API version in new specs and examples * Add new resources for 2022-06-01-preview (Azure#19494) * update * update * update * fix * update * update * update * update * fix * update * update * Enable Dapr AI Connection string for Microsoft.App connected environment (Azure#19974) * Enable Dapr AI Connection string for Microsoft.App connected environment * Fix dapr ai connection string * remove read * remove read permission of dapr ai connection string and instrument key for managed environment * fixes for comments * update (Azure#20013) * Fixdescriptions on microsoft.app 2022 06 01 preview (Azure#20133) * Fix casing for detector properties * Fix descriptions * Fix descriptions and detectorProperties in 2022-06-01-preview * Added `secretsStoreComponent` in 2022-06-01 spec (Azure#20044) * Added `secretsStoreComponent` in 2022-06-01 spec Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com> * Fixed typos and added example of name/key Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com> * Add custom domain configuration for managed environment (Azure#20149) Co-authored-by: Mengjun Qin <menqin@microsoft.com> * Add additional Dapr options (2022-06-01-preview) (Azure#19886) * Add additional Dapr options * Update examples for 2022-06-01-preview * force ci * force ci * force ci * adding ip-restriction feat (Azure#19841) * adding ip-restriction feat * remove from stable, add to preview * fix lintDiff error * fix modelvalidation error * fix formatting changes * rename names, add note to all allow or all deny * fix spell check error * update name and examples * rename `ipAddress` to `ipAddressRange` * making small change to re-run build pipeline * trigger GitHub actions * resolve comments Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com> * Remove Traffic Labels from revisions because they haven't been impelemented (Azure#20261) * Revert "Add traffic info to revisions api (Azure#19054)" This reverts commit 056cc51226bf2eef3d3a7e7bdca875a4a571026b. * Remove traffic labels from revisions * Add property for tcp apps (Azure#20193) * Add property for tcp apps * Add scale * Fix * Fix * Add Init Containers to common definitions (Azure#19855) * add init containers to common definitions * move changes to 06-01 preview * remove repeated container definition * fix allof syntax * fix anonymous container definition * fix lintdiff errors * fix container allof syntax * add more init examples * split baseContainer definition * remove description Co-authored-by: p-bouchon <pbouchon@microsoft.com> * Update container app provisioningstate (Azure#20411) * update * update * add property: maxInactiveRevisions (Azure#20334) * add property: maxInactiveRevisions * update * update * Add premium sku related properties for managed environment (Azure#19770) * Add premium sku related properties for managed environment * Move sku to base property * Add workloadProfileType * Examples for managed environment * Add container app example * Fix workloadProfiles * Add custom word * Fix WorkloadProfileType references * prettier fixes * Fix workload profile * Fix typo * remove readonly property for workload profile * Add object type * nit: Fix description location * Fix XmsIdentifierValidation * Remove spaces from enum values * Remove unwanted change * Add aka ms url * Update examples for workload profile type * Fix rebase issue * Fix json * Update description and move location * Remove provisioning state for node pool * sku capacity explanation * Remove capacity attribute * Remove capacity attribute from required * Mark sku property as required * Add x-ms-identifiers * Rename mimum and maximum * Rename skutype to skuName * Make sku property as optional * Make workload profile type as string * fix go SDK automation config Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn> * Fix source control status code in 2022-06-01-preview. (Azure#20429) * Swagger documentation for /locations/{location}/billingMeters - GET endpoint * Add example, fix validation errors * Fix ARM validation errors, code review comments * Fix response validation * Remove 20220501 because we will not support it in server side (Azure#20427) * remove * update * add proxy resource properties * Response formatting * Added support for user defined routing (Azure#20464) * Added support for user defined routing * Added examples * fixed JSON syntax * syntax fix * fixed vnetenvironment syntax * fixed camel case * case fix * enum syntax * fixed comma cases ManagedEnvironmentOutBoundType * fixing casing * add default error response * Add available workprofiles -GET endpoint * Remove duplicate schema name WorkloadProfile * Change memoryGiB to memoryGB as suggested in code review * Add x-ms-pageable - nextLink support to not introduce breaking changes in the future * rename to memory in GiB because our case is Gibibytes base 1024 * change friendlyName to displayName * Some more APIs (Azure#20448) * new APIs to 06-01 * test fix * more fixes * Add new property to the response object * add last active time for revision (Azure#20658) * Add custom domain for connected env (Azure#20731) * add custom domain * fhcekout * billingMeters - GET endpoint (Azure#20485) * Swagger documentation for /locations/{location}/billingMeters - GET endpoint * Add example, fix validation errors * Fix ARM validation errors, code review comments * Fix response validation * add proxy resource properties * Response formatting * add default error response * ARM Review feedback + small naming change for a property * Change GB to GiB * Change the boolean value for default to enum * change error response to v3/ErrorResponse * Fix 2022-06-01-preview branch merge conflicts (Azure#20773) * Reset * more fixes * More fixes * another conflict fix * Fix old preview version * fix 2022-03-01 Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com> Co-authored-by: Ruslan Yakushev <1664475+ruslany@users.noreply.github.com> Co-authored-by: michimune <michimune@outlook.com> Co-authored-by: Michimune Kohno <mikono@microsoft.com> Co-authored-by: Zunli Hu <zuh@microsoft.com> Co-authored-by: Mike Vu <mikevu@microsoft.com> Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu> Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com> Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com> Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com> Co-authored-by: Mengjun Qin <767524684@qq.com> Co-authored-by: Mengjun Qin <menqin@microsoft.com> Co-authored-by: Taher Daroly <41846928+tdaroly@users.noreply.github.com> Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com> Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com> Co-authored-by: p-bouchon <107427816+p-bouchon@users.noreply.github.com> Co-authored-by: p-bouchon <pbouchon@microsoft.com> Co-authored-by: njucz <740360112@qq.com> Co-authored-by: JJ <jijohn@microsoft.com> Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn> Co-authored-by: yalixiang <88011184+yalixiang@users.noreply.github.com> Co-authored-by: Mahmoud Desokey <desokey@yahoo.com> Co-authored-by: Xingjian Wang <79332479+xwang971@users.noreply.github.com>