[ServiceBus] Improve test stability and cpu usage #20352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yunhaoling
commented
Aug 19, 2021
| @@ -1595,8 +1595,8 @@ def callback_mock(renewable, error): | |||
| auto_lock_renew = AutoLockRenewer() | |||
| auto_lock_renew._renew_period = 1 | |||
| with auto_lock_renew: # Check that in normal operation it does not get called | |||
| auto_lock_renew.register(receiver, renewable=MockReceivedMessage(), on_lock_renew_failure=callback_mock) | |||
| time.sleep(3) | |||
| auto_lock_renew.register(receiver, renewable=MockReceivedMessage(lock_duration=5), on_lock_renew_failure=callback_mock) | |||
There was a problem hiding this comment.
in this test case, 2 seconds would result in random failure on windows, so increasing the time a bit to let AutoLockRenewer to have enough time for renewing work.
also, the minimum allowed lock duration by the service is 5 seconds
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yunhaoling
requested review from
annatisch,
rakshith91 and
swathipil
as code owners
|
/check-enforcer reset |
|
/check-enforcer evaluate |
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Aug 30, 2021
…t/azure-sdk-for-python into switch_to_protocol * 'remove_iter_text_lines' of https://github.com/iscai-msft/azure-sdk-for-python: update tests remove iter_text and iter_lines [ServiceBus] Improve test stability and cpu usage (Azure#20352) t2-Netapp-update-to-2021-06-01 (Azure#20453) [AutoRelease] t2-keyvault-2021-08-26-55443 (Azure#20423) Sync eng/common directory with azure-sdk-tools for PR 1943 (Azure#20450) New dummy password in README (Azure#20328)
iscai-msft
added a commit
that referenced
this pull request
Aug 31, 2021
…into header_tuples * 'main' of https://github.com/Azure/azure-sdk-for-python: (21 commits) [Key Vault] Add 7.3-preview support for certificates (#20477) Use dummy values and correct code rendering in README (#20322) Use CredScan-suppressed dummy password in sample (#20468) Fix type annotation in azure.storage.blob (#20084) Adding static checks (#20457) release_iseus_status_auto_reply (#20441) Clarify LogsQueryClient query parameter description (#20467) Sync eng/common directory with azure-sdk-tools for PR 1953 (#20466) Skip eng common workflow enforcer for private repos (#20462) remove iter_text and iter_lines (#20460) [ServiceBus] Improve test stability and cpu usage (#20352) t2-Netapp-update-to-2021-06-01 (#20453) [AutoRelease] t2-keyvault-2021-08-26-55443 (#20423) Sync eng/common directory with azure-sdk-tools for PR 1943 (#20450) New dummy password in README (#20328) ensure test principal creation succeeds properly (#20446) Update question-answering readme links (#20439) Stip empty changelog sections before release (#20437) [AutoRelease] t2-healthcareapis-2021-08-26-27542 (#20422) [AutoRelease] t2-iothub-2021-08-25-25696 (#20409) ...
iscai-msft
pushed a commit
that referenced
this pull request
Sep 29, 2021
* updatet test and improve cpu usage * update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressing issue:
#20354
#20312