[Communication] - SDK - Renamed remaining connection string EV references #18682
Conversation
jbeauregardb
requested review from
ankitarorabit,
memontic-ms and
a team
as code owners
ghost
added
the
jbeauregardb
force-pushed
the
evRename
branch
2 times, most recently
from
997201e
to
3891bed
Compare
|
/azp run python - communication - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdk/communication/CONTRIBUTING.md
Outdated
| @@ -27,7 +27,7 @@ If the tests are successful, we can proceed to run the tests in LIVE mode. | |||
|
|
|||
| ### Live mode | |||
|
|
|||
| Because in LIVE mode we are hitting an actual resource, we must set the appropriate environment variable to make sure the code tests against the resource we want. Set up an env variable called `AZURE_COMMUNICATION_SERVICE_CONNECTION_STRING` and set it to the connection string of the resource you want to test against. | |||
| Because in LIVE mode we are hitting an actual resource, we must set the appropriate environment variable to make sure the code tests against the resource we want. Set up an env variable called `COMMUNICATION_LIVETEST_STATIC_CONNECTION_STRING` and set it to the connection string of the resource you want to test against. | |||
There was a problem hiding this comment.
Maybe you can add a line saying this is only needed for SMS and Phone Numbers.
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
|
/azp run python - communication - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…into add_logging_param * 'master' of https://github.com/Azure/azure-sdk-for-python: (33 commits) [text analytics] rerecord (Azure#18731) [agrifood] generation for azure-agrifood-farming (Azure#18713) [SB/EH] temporarily remove mgmt from ci pipeline (Azure#18724) bump core version (Azure#18723) Added policy Reset APIs; Cleaned up several model types. (Azure#18679) update release date (Azure#18704) Fixed PathProperties class init issue (Azure#18559) [agrifood] ignore swagger readme (Azure#18714) update for aiohttp 3.6 (Azure#18715) Renamed remaining connection string EV references (Azure#18682) Increment package version after release of azure-containerregistry (Azure#18683) skip live recording (Azure#18712) Increment package version after release of azure-identity (Azure#18710) Sample demonstrating authentication with a Key Vault certificate (Azure#18109) [AutoRelease] t2-storage-2021-05-13-13723 (Azure#18691) [AutoRelease] t2-loganalytics-2021-05-13-47912 (Azure#18694) useless sdk folder del (Azure#18688) [AutoRelease] t2-resource-2021-05-13-95786 (Azure#18686) update release date (Azure#18689) bump autorest version from '3.3.0' to '3.4.2' (Azure#18662) ...
No description provided.