[Service Bus] reduce livetest time #18176
Conversation
swathipil
requested review from
00Kai0,
annatisch,
changlong-liu,
jsntcy,
msyyc,
rakshith91 and
yunhaoling
as code owners
ghost
added
the
|
@swathipil , this is great! let's kick off the livetest pipeline to see how much time you have saved 😉 |
sdk/servicebus/azure-servicebus/tests/async_tests/mgmt_tests/test_mgmt_queues_async.py
Show resolved
Hide resolved
| @@ -231,7 +231,7 @@ async def test_async_queue_by_queue_client_conn_str_receive_handler_receiveandde | |||
|
|
|||
| assert not receiver._running | |||
| assert len(messages) == 10 | |||
| time.sleep(30) | |||
| time.sleep(10) | |||
There was a problem hiding this comment.
can we ensure this will not increase the number of transient failures? same question for all similar changes
There was a problem hiding this comment.
that's a good point. I'm not sure that this won't increase transient failures. Do you know what the best way to check that would be?
There was a problem hiding this comment.
@rakshith91 thanks for being thoughtful!
as far as I could remember, the transient failures are usually caused by tests including receiving which doesn't wait long enough.
I think we could merge the PR first and see how it goes, if we keep observing failures, then we fix them :P
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
* change mgmt livetests to recordings * set lock duration low for less sleep
[Hub Generated] Review request for Microsoft.ContainerRegistry to add version preview/2022-02-01-preview (Azure#18176)
fixes: #13056