[Key Vault] Add EncryptParameters analog in Python #16840
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccoyp
added
KeyVault
Client
mccoyp
commented
Feb 20, 2021
| def __init__(self, algorithm, **kwargs): | ||
| self.algorithm = algorithm | ||
| self.iv = kwargs.pop("iv", None) | ||
| self.additional_authenticated_data = kwargs.pop("additional_authenticated_data", None) |
There was a problem hiding this comment.
Question here: it's easy to imagine a user using these constructors directly. In that case, should we use the argument validation helper from _client.py in __init__? We could also validate arguments during calls to encrypt/decrypt like we do when an EncryptionAlgorithm is provided, but that wouldn't give us the chance to raise an error when the configuration is defined.
mccoyp
force-pushed
the
encryptparams
branch
from
868f57e to
45872e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
EncryptionAlgorithmConfigurationandDecryptionAlgorithmConfigurationclasses, which are accepted as analgorithmargument inencryptanddecrypt, respectively, to lead users to provide appropriate arguments to encryption algorithms.