Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Communication]: SMS 1:N Messages, Custom Tags, and Idempotence #16836

Merged
merged 28 commits into from
Mar 2, 2021
Merged

[Communication]: SMS 1:N Messages, Custom Tags, and Idempotence #16836

merged 28 commits into from
Mar 2, 2021

Conversation

lsundaralingam
Copy link
Member

@ghost ghost added the Communication label Feb 20, 2021
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@lsundaralingam
Copy link
Member Author

/azp run python - communication - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lsundaralingam lsundaralingam changed the title [Communication]: SMS 1:N Messages and Custom Tags [Communication]: SMS 1:N Messages, Custom Tags, and Idempotence Feb 23, 2021
@lsundaralingam
Copy link
Member Author

/azp run python - communication - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lsundaralingam
Copy link
Member Author

/azp run python - communication - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lsundaralingam
Copy link
Member Author

/azp run python - communication - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lsundaralingam lsundaralingam marked this pull request as ready for review February 24, 2021 21:37
@lsundaralingam
Copy link
Member Author

/azp run python - communication - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

ankitarorabit
ankitarorabit reviewed Feb 26, 2021
View reviewed changes
sdk/communication/azure-communication-sms/azure/communication/sms/_sms_client.py Outdated
SmsRecipient(
to=p,
repeatability_request_id=str(uuid4()),
repeatability_first_sent=datetime.now()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything needed to make it cultural neutral or is that not a problem?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this should be datetime.utcnow() , so it uses a standard time zone. We're also using UTC in other languages.

ankitarorabit
ankitarorabit reviewed Feb 26, 2021
View reviewed changes
sdk/communication/azure-communication-sms/samples/sms_sample.py Outdated
print("Message with message id {} was successful sent to {}"
.format(sms_response.message_id , sms_response.to))
else:
print("Message failed to send to {}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be good to print the actual code and errorMessage

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, I'll update this.

@lsundaralingam
Copy link
Member Author

/azp run python - communication - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

ankitarorabit
ankitarorabit reviewed Mar 1, 2021
View reviewed changes
sdk/communication/azure-communication-sms/azure/communication/sms/_sms_client.py Outdated
message on the Azure Resource EventGrid.
:keyword str tag: Use this field to provide metadata that will then be sent back in the corresponding
Delivery Report.
:return: A list of SmsSendResults.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: SmsSendResult

@ankitarorabit ankitarorabit merged commit e1b84af into Azure:master Mar 2, 2021
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Mar 3, 2021
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
5727484 
…into http_request_json

* 'master' of https://github.com/Azure/azure-sdk-for-python: (147 commits)
  [text analytics] add perf tests (Azure#17060)
  Add cloud event to core (Azure#16800)
  [Perf] Small fixes to storage-blob (Azure#17055)
  [EG] Regenerate Code (Azure#17053)
  Scrub batch shared keys (Azure#17030)
  [Tables] Add SAS to tables (Azure#16717)
  T2 containerservice 2021 03 03 (Azure#17050)
  Addressing issues with CredScan (Azure#16944)
  Communication chat preview4 (Azure#16905) (Azure#17037)
  remove first query section (Azure#17033)
  [formrecognizer] temp disable sample tests until service bug fixed (Azure#17036)
  [device update] allow device update pylint failures (Azure#17034)
  fix build (Azure#17029)
  update artifact names for ALL packages to align with the actual package name
  Create azure-iot-nspkg (Azure#17026)
  [Communication]: SMS 1:N Messages, Custom Tags, and Idempotence (Azure#16836)
  Fixing credentials to use AAD (Azure#16885)
  T2 deviceupdate 2021 03 02 (Azure#17016)
  T2 cosmosdb 2021 02 23 (Azure#16875)
  T2 datadog 2021 03 02 (Azure#17004)
  ...
@lsundaralingam lsundaralingam deleted the communication-sms branch March 26, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitarorabit ankitarorabit ankitarorabit approved these changes

@beltr0n beltr0n Awaiting requested review from beltr0n

@paolamvhz paolamvhz Awaiting requested review from paolamvhz

@turalf turalf Awaiting requested review from turalf

@sacheu sacheu Awaiting requested review from sacheu

@jbeauregardb jbeauregardb Awaiting requested review from jbeauregardb

@memontic-ms memontic-ms Awaiting requested review from memontic-ms

Assignees
No one assigned
Labels
Communication
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lsundaralingam @ankitarorabit