-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve samples in EG #16821
Improve samples in EG #16821
Conversation
/azp run python - eventgrid - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run python - eventgrid - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run python - eventgrid - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run python - eventgrid - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run python - eventgrid - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some smaller changes, but lgtm 👍
...d/azure-eventgrid/samples/consume_samples/consume_eventgrid_events_from_service_bus_queue.py
Outdated
Show resolved
Hide resolved
sdk/eventgrid/azure-eventgrid/samples/sync_samples/sample_publish_custom_schema_to_a_topic.py
Outdated
Show resolved
Hide resolved
...grid/azure-eventgrid/samples/sync_samples/sample_publish_events_to_a_topic_with_signature.py
Outdated
Show resolved
Hide resolved
DESCRIPTION: | ||
These samples demonstrate sending an EventGrid Event using a shared access signature for authentication. | ||
USAGE: | ||
python cs1b_publish_custom_events_to_a_topic_with_signature.py | ||
python sample_publish_custom_events_to_a_topic_with_signature.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
...grid/azure-eventgrid/samples/sync_samples/sample_publish_events_to_a_topic_with_signature.py
Outdated
Show resolved
Hide resolved
Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>
/azp run python - eventgrid - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a couple more small comments
...entgrid/azure-eventgrid/samples/async_samples/sample_publish_cloud_event_using_dict_async.py
Outdated
Show resolved
Hide resolved
sdk/eventgrid/azure-eventgrid/samples/sync_samples/sample_publish_cloud_event_using_dict.py
Outdated
Show resolved
Hide resolved
Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>
/azp run python - eventgrid - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run python - eventgrid - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
Fixes #16242
Fixes #13582