Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve samples in EG #16821

Merged
merged 18 commits into from
Feb 23, 2021
Merged

Improve samples in EG #16821

merged 18 commits into from
Feb 23, 2021

Conversation

rakshith91
Copy link
Contributor

@rakshith91 rakshith91 commented Feb 19, 2021

Fixes #16242
Fixes #13582

@ghost ghost added the Event Grid label Feb 19, 2021
@rakshith91
Copy link
Contributor Author

/azp run python - eventgrid - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rakshith91
Copy link
Contributor Author

/azp run python - eventgrid - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rakshith91
Copy link
Contributor Author

/azp run python - eventgrid - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rakshith91 rakshith91 marked this pull request as ready for review February 22, 2021 20:03
@rakshith91
Copy link
Contributor Author

/azp run python - eventgrid - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rakshith91
Copy link
Contributor Author

/azp run python - eventgrid - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@swathipil swathipil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some smaller changes, but lgtm 👍

sdk/eventgrid/azure-eventgrid/samples/README.md Outdated Show resolved Hide resolved
sdk/eventgrid/azure-eventgrid/samples/README.md Outdated Show resolved Hide resolved
sdk/eventgrid/azure-eventgrid/samples/README.md Outdated Show resolved Hide resolved
sdk/eventgrid/azure-eventgrid/README.md Outdated Show resolved Hide resolved
sdk/eventgrid/azure-eventgrid/README.md Outdated Show resolved Hide resolved
DESCRIPTION:
These samples demonstrate sending an EventGrid Event using a shared access signature for authentication.
USAGE:
python cs1b_publish_custom_events_to_a_topic_with_signature.py
python sample_publish_custom_events_to_a_topic_with_signature.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Rakshith Bhyravabhotla and others added 3 commits February 22, 2021 14:51
Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>
@rakshith91
Copy link
Contributor Author

/azp run python - eventgrid - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@swathipil swathipil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a couple more small comments

rakshith91 and others added 2 commits February 22, 2021 15:44
Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>
@rakshith91
Copy link
Contributor Author

/azp run python - eventgrid - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rakshith91
Copy link
Contributor Author

/azp run python - eventgrid - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rakshith91 rakshith91 merged commit 3c4f257 into Azure:master Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EventGrid] Update naming/comments in sync samples [EventGrid] ADd more samples
2 participants