Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of Azure ML managed identity responses #16536

Merged
merged 4 commits into from
Feb 5, 2021

Conversation

chlowell
Copy link
Member

@chlowell chlowell commented Feb 4, 2021

This fixes #15361 by relaxing ManagedIdentityCredential's response parsing. More durable support for Azure ML managed identity may require other changes as the feature evolves (currently it's in preview). #16533 tracks adding a live test for Azure ML.

@chlowell chlowell added Client This issue points to a problem in the data-plane of the library. Azure.Identity labels Feb 4, 2021
Copy link
Member

@mccoyp mccoyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@chlowell chlowell merged commit 79f7d0b into Azure:master Feb 5, 2021
@chlowell chlowell deleted the azureml branch February 5, 2021 21:58
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Nov 8, 2021
Add {release|rotate}-related AKV key permissions for 2021-06-01-preview. (Azure#16536)
msyyc added a commit that referenced this pull request Nov 11, 2021
* CodeGen from PR 16536 in Azure/azure-rest-api-specs
Add {release|rotate}-related AKV key permissions for 2021-06-01-preview. (#16536)

* version,CHANGELOG

* test

* version

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ManagedIdentityCredential.get_token failed: 'int' object has no attribute 'endswith'
2 participants