Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename generate_shared_access_signature to generate_sas #16330

Merged
merged 2 commits into from
Jan 25, 2021

Conversation

rakshith91
Copy link
Contributor

@rakshith91 rakshith91 commented Jan 25, 2021

Fixes #16328

Updated:
tests/
samples/
code/
CHANGELOG.md

nothing on migration_guide , README

Co-authored-by: Adam Ling (MSFT) <adam_ling@outlook.com>
@rakshith91
Copy link
Contributor Author

/azp run python - eventgrid - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@yunhaoling yunhaoling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rakshith91
Copy link
Contributor Author

/azp run python - eventgrid - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rakshith91
Copy link
Contributor Author

/azp run python - eventgrid - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rakshith91 rakshith91 merged commit 8c725c5 into Azure:master Jan 25, 2021
@rakshith91 rakshith91 deleted the gen_sas branch January 25, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rename generate_shared_access_signature to generate_sas
2 participants