Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing enter, exit and close on publisher clients #16321

Merged
merged 1 commit into from
Jan 25, 2021
Merged

Missing enter, exit and close on publisher clients #16321

merged 1 commit into from
Jan 25, 2021

Conversation

rakshith91
Copy link
Contributor

@rakshith91 rakshith91 commented Jan 25, 2021 •
edited
Loading

Fixes #16126

@ghost ghost added the Event Grid label Jan 25, 2021
@rakshith91
Copy link
Contributor Author

/azp run python - eventgrid - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rakshith91 rakshith91 marked this pull request as ready for review January 25, 2021 18:12
swathipil
swathipil approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@swathipil swathipil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rakshith91 rakshith91 merged commit 0ae2052 into Azure:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swathipil swathipil swathipil approved these changes

@lmazuel lmazuel Awaiting requested review from lmazuel

@yunhaoling yunhaoling Awaiting requested review from yunhaoling

Assignees
No one assigned
Labels
Event Grid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[EventGrid] async EventGridPublisherClient does not close session
2 participants
@rakshith91 @swathipil