[eventgrid] add tests for samples #16033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
rakshith91
commented
Jan 8, 2021
sdk/eventgrid/azure-eventgrid/samples/champion_scenarios/cs3_consume_system_events.py
Outdated
Show resolved
Hide resolved
…onsume_system_events.py
rakshith91
commented
Jan 8, 2021
| @@ -15,8 +15,9 @@ | |||
| from azure.eventgrid import EventGridConsumer | |||
|
|
|||
| consumer = EventGridConsumer() | |||
| path = os.path.abspath(os.path.join(os.path.abspath(__file__), "..", "./cs3_consume_system_events.json")) | |||
There was a problem hiding this comment.
Suggested change
| path = os.path.abspath(os.path.join(os.path.abspath(__file__), "..", "./cs3_consume_system_events.json")) | |
| path = os.path.abspath(os.path.join(os.path.abspath(__file__), "..", "./cs3_system_event.json")) |
rakshith91
commented
Jan 8, 2021
sdk/eventgrid/azure-eventgrid/samples/champion_scenarios/cs3_consume_system_events.py
Outdated
Show resolved
Hide resolved
rakshith91
commented
Jan 8, 2021
| "consume_cloud_events_from_eventhub.py", | ||
| "consume_cloud_events_from_service_bus_queue.py", | ||
| "consume_cloud_events_from_storage_queue.py", | ||
| "cs2_publish_custom_events_to_a_domain_topic"] |
There was a problem hiding this comment.
Will be fixed in this #16042
rakshith91
commented
Jan 8, 2021
rakshith91
requested review from
danieljurek,
KieranBrantnerMagee and
lmazuel
as code owners
rakshith91
commented
Jan 8, 2021
yunhaoling
reviewed
Jan 8, 2021
kristapratico
approved these changes
Jan 8, 2021
yunhaoling
approved these changes
Jan 8, 2021
already did and shared the link on the pr description |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Samples are triggered in the live run
Example: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=679428&view=results
Fixes #14322