[Storage][LiveTest]replace the fixed blob names #15862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiafu-msft
requested review from
amishra-dev,
annatisch,
kasobol-msft,
rakshith91,
tasherif-msft and
zezha-msft
as code owners
ghost
added
the
kasobol-msft
approved these changes
Dec 18, 2020
|
LGTM I think some more tests need to be rerecorded for CI to be green. |
tasherif-msft
approved these changes
Dec 18, 2020
| self.bsc.create_container(self.container_name) | ||
| try: | ||
| self.bsc.create_container(self.container_name) | ||
| except: |
There was a problem hiding this comment.
Good point. I think we should catch the specific exception just to be safe, so in this case except ResourceExistsError:
rakshith91
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Jan 8, 2021
* [Storage][LiveTest]replace the fixed blob names * re-record
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.