[Communication] Add variables necessary for using new azure subscription for SMS live tests #15213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turalf
requested review from
ankitarorabit,
RezaJooyandeh and
a team
as code owners
| @@ -15,7 +15,7 @@ | |||
| ResponseReplacerProcessor | |||
| ) | |||
|
|
|||
| SKIP_PHONE_NUMBER_TESTS = True | |||
| SKIP_PHONE_NUMBER_TESTS = False | |||
| PHONE_NUMBER_TEST_SKIP_REASON= "Phone Number infra for live tests not ready yet" | |||
There was a problem hiding this comment.
nit: remove this comment?
ankitarorabit
previously approved these changes
Nov 12, 2020
|
/azp run python - communication - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ankitarorabit
previously approved these changes
Nov 12, 2020
|
/azp run python - communication - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - communication - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - communication - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ankitarorabit
approved these changes
Nov 13, 2020
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Nov 14, 2020
…into new_polling * 'master' of https://github.com/Azure/azure-sdk-for-python: (281 commits) [Communication] Add variable groups necessary for using new azure subscription (Azure#15213) Sync eng/common directory with azure-sdk-tools for PR 1153 (Azure#15322) [Communication] Update version for Preview 3 release (Azure#15317) Increment package version after release of azure_data_tables (Azure#15291) [monitor] README + samples _ ci.yml (Azure#15288) refdoc aka.ms link was broken and silently redirecting, have replaced with azuresdkdocs link as is used in other SDKs. (Azure#15169) Sync eng/common directory with azure-sdk-tools for PR 1202 (Azure#15297) Updating OT exporter to consume latest version of OpenTelemetry API/SDK (Azure#15289) Change live test resource DeleteAfterHours tag to 8 hours (Azure#15294) Add Invoke-DevOpsAPI.ps1, Add functions for Canceling and Listing Builds (Azure#15013) The original one is removed. Point to the new one (Azure#15287) Sync eng/common directory with azure-sdk-tools for PR 1170 (Azure#15087) Adding OpenTelemetry exporter code (Azure#14784) update external link (Azure#15273) Remove invalid characters in basename sourced from username (Azure#15268) Sync eng/common directory with azure-sdk-tools for PR 1188 (Azure#15267) Increment version for core releases (Azure#15269) Increment package version after release of azure_identity (Azure#15266) Fix CI (Azure#15265) Increment package version after release of azure_eventgrid (Azure#15262) ...
turalf
changed the title
turalf
changed the title
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
Aug 27, 2021
[NetAppFiles] s360 fixes to 2021-01 (Azure#15213) * Apply s360 fixes * Fix typo * Rename op, add example * Remove snapshotpolicy listVolumes false positive, fix description for snapshotNamne property all versions * ReplicationSceheduled is no longer required in ReplicationObject Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using the new subscription for our testing.
The new subscription id is added to the keyvault and this PR changes the tests.yml to access that subscriptionId.
This PR also enabled the SMS tests based on the static resources which live in a new subscription.