Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[text analytics] add output to opinion mining sample #13494

Merged
merged 1 commit into from
Sep 1, 2020
Merged

[text analytics] add output to opinion mining sample #13494

merged 1 commit into from
Sep 1, 2020

Conversation

iscai-msft
Copy link
Contributor

fixes #13120

kristapratico
kristapratico approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@kristapratico kristapratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still worried about output changing as model versions change, but I guess it's necessary to understand the concepts

@iscai-msft iscai-msft merged commit f18cce0 into Azure:master Sep 1, 2020
@iscai-msft iscai-msft deleted the add_print_output_to_sample branch September 1, 2020 21:52
@maririos
Copy link
Member

maririos commented Sep 1, 2020

Still worried about output changing as model versions change

We could send the request with a specific model version and that way we know the output won't change. What do you think?
@iscai-msft @kristapratico

iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Sep 2, 2020
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
f7625ea 
…into link_om_sample

* 'master' of https://github.com/Azure/azure-sdk-for-python: (23 commits)
  Int32 serialization (Azure#13452)
  add output to opinion mining sample (Azure#13494)
  Add Document w/ Eng Sys Checks (Azure#13492)
  update version (Azure#13495)
  Remove resources post test (Azure#13379)
  bing_id -> bing_entity_search_api_id (Azure#13491)
  [EventGrid] Read me + improve docstrings (Azure#13484)
  Build AuthenticationRecords from ADFS identity tokens (Azure#13341)
  Support Subject Name/Issuer authentication (Azure#13350)
  Add KeyVaultAccessControlClient for data plane RBAC (Azure#13372)
  [text analytics] Add redacted_text (Azure#13449)
  add python sdk sample (Azure#13338)
  [text analytics] add versionadded sphinx documentation (Azure#13450)
  [text analytics] add bing_id property to LinkedEntity class (Azure#13446)
  fix typing for paging methods (Azure#13410)
  [text analytics] add domain_filter param (Azure#13451)
  fix issue Azure#11658 for is_valid_resource_id (Azure#11709)
  added create_table_if_not_exists method to table service client (Azure#13385)
  [ServiceBus] Test and failure improvements (Azure#13345)
  Proper encoding and decoding of source URLs - Fixes special characters in source URL issue (Azure#13275)
  ...
@iscai-msft
Copy link
Contributor Author

@maririos I think it's better to not add it because users might think that model version is more necessary than it is since we've included it in a sample. The output of this sample is also not super finnicky (i.e. i don't think it should change that much with diff model versions), since I'm only outputting the aspect and opinion text with the sentiment. But I def understand the concerns, I think I'll keep it without model version for now. If it becomes necessary in the future, I'll look into adding the model version

rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Sep 4, 2020
@iscai-msft @rakshith91
add output to opinion mining sample (Azure#13494)
35b095d
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Mar 30, 2021
CodeGen from PR 13494 in Azure/azure-rest-api-specs
40eddb3 
datamigration readme t2 config (Azure#13494)

* datamigration readme t2 config

* datamigration readme change

* datamigration readme change V2

* dataMigration readme change
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Mar 30, 2021
CodeGen from PR 13494 in Azure/azure-rest-api-specs
6493a6d 
datamigration readme t2 config (Azure#13494)

* datamigration readme t2 config

* datamigration readme change

* datamigration readme change V2

* dataMigration readme change
00Kai0 pushed a commit that referenced this pull request Apr 7, 2021
@msyyc @RAY-316
[AutoRelease] t2-datamigration-2021-04-07-23754(wave4) (#17861)
f16535e 
* CodeGen from PR 13494 in Azure/azure-rest-api-specs
datamigration readme t2 config (#13494)

* datamigration readme t2 config

* datamigration readme change

* datamigration readme change V2

* dataMigration readme change

* version,CHANGELOG

* test

* datamigration changelog config

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Zed Lei <59104634+RAY-316@users.noreply.github.com>
Co-authored-by: Zed <601306339@qq.com>
mccoyp pushed a commit to mccoyp/azure-sdk-for-python that referenced this pull request Apr 9, 2021
@msyyc @RAY-316 @mccoyp
[AutoRelease] t2-datamigration-2021-04-07-23754(wave4) (Azure#17861)
bfd53a5 
* CodeGen from PR 13494 in Azure/azure-rest-api-specs
datamigration readme t2 config (Azure#13494)

* datamigration readme t2 config

* datamigration readme change

* datamigration readme change V2

* dataMigration readme change

* version,CHANGELOG

* test

* datamigration changelog config

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Zed Lei <59104634+RAY-316@users.noreply.github.com>
Co-authored-by: Zed <601306339@qq.com>
mccoyp pushed a commit to mccoyp/azure-sdk-for-python that referenced this pull request Apr 13, 2021
@msyyc @RAY-316 @mccoyp
[AutoRelease] t2-datamigration-2021-04-07-23754(wave4) (Azure#17861)
401c176 
* CodeGen from PR 13494 in Azure/azure-rest-api-specs
datamigration readme t2 config (Azure#13494)

* datamigration readme t2 config

* datamigration readme change

* datamigration readme change V2

* dataMigration readme change

* version,CHANGELOG

* test

* datamigration changelog config

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Zed Lei <59104634+RAY-316@users.noreply.github.com>
Co-authored-by: Zed <601306339@qq.com>
benbp pushed a commit to benbp/azure-sdk-for-python that referenced this pull request Apr 19, 2021
@msyyc @RAY-316 @benbp
[AutoRelease] t2-datamigration-2021-04-07-23754(wave4) (Azure#17861)
083f6b1 
* CodeGen from PR 13494 in Azure/azure-rest-api-specs
datamigration readme t2 config (Azure#13494)

* datamigration readme t2 config

* datamigration readme change

* datamigration readme change V2

* dataMigration readme change

* version,CHANGELOG

* test

* datamigration changelog config

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Zed Lei <59104634+RAY-316@users.noreply.github.com>
Co-authored-by: Zed <601306339@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristapratico kristapratico kristapratico approved these changes

@maririos maririos Awaiting requested review from maririos

@mssfang mssfang Awaiting requested review from mssfang

@deyaaeldeen deyaaeldeen Awaiting requested review from deyaaeldeen

Assignees
No one assigned
Labels
Cognitive - Text Analytics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[text analytics] add print output to sample for opinion mining
3 participants
@iscai-msft @maririos @kristapratico