Feature/storage stg73 #12272
Merged
Feature/storage stg73 #12272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [Blob][Swagger]Regenerate Swagger Code * fix container test failure caused by list_containers include type change
* initial avro parser
* try fixing test...
* falling in love with python compatibility...
* make linter happy.
* raise StopIteration when there is no more bytes instead of tracking file length.
* async avro parser
* fix syntax for Python 3.5
* get rid of 'readers_schema' as we only honor schema that has been written to file ('writer_schema').
* pr feedback
* trim unused code.
* pr feedback.
* simplify skip sync in next.
* move avro tests from _shared.
* wip * initial test coverage. * wip. * wip * single upload. * add async tests. * disable 50k block tests. * datalake append. * async datalake * disable tests that send large payload over network. * pr feedback.
* [Storage][STG73]Address API Review Comments * [Storage][STG73]dict<policy, rules> -> list(ObjectReplicationPolicy) * fix blob tag_value test * expose ObjectReplicationPolicy and ObjectReplicationRule, fix test * fix test
* [ChangeFeed]Add ChangeFeed Package * test_avro failure * update dev_requirement.txt * change namespace to azure.storage.blob.changefeed * address comments * optimize memory when reading changefeed events * namespace change * set up package change * fix failed tests * readme and kwargs * Update sdk/storage/azure-storage-blob-changefeed/azure/storage/blob/changefeed/_change_feed_client.py Co-authored-by: Rakshith Bhyravabhotla <sabhyrav@microsoft.com> * address comments * 'azure-storage-blob>=12.3.0' which does not match the frozen requirement 'azure-storage-blob~=1.3' Co-authored-by: Rakshith Bhyravabhotla <sabhyrav@microsoft.com>
* Renamed query error * Renamed query reader * Updated config models * Updated format request params * Updated iterator * fix the bug which caused only showing fatal error * Updated Error message * Fixed query helper * Started test conversion * small fix * Fixed tests * Updated error handling + json model * Updated recordings * Removed old recording * Added iter tests * Iter test recordings * Fix test * Remove extra recording * Fix pylint * Some docs cleanup * Renamed iter_records -> iter_stream * Review feedback * Updated tests * Missing commas * Fix syntax * Fix pylint Co-authored-by: xiafu <xiafu@microsoft.com>
xiafu-msft
requested review from
amishra-dev,
annatisch,
danieljurek,
mitchdenny,
rakshith91,
scbedd,
weshaggard and
zezha-msft
as code owners
|
/azp run python - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Merged
|
/azp run python - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xiafu-msft
commented
Jul 1, 2020
| @@ -324,10 +324,15 @@ class AccountSasPermissions(object): | |||
| Valid for the following Object resource types only: queue messages. | |||
| :param bool process: | |||
| Valid for the following Object resource type only: queue messages. | |||
| :param bool tag: | |||
There was a problem hiding this comment.
Discussed with Anna offline:
"tag" should probably be "tags".
And these should all probably go into kwargs and be :keyword:
|
/azp run python - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
* [Storage][JumboBlob]remove empty super() * pypy3 * change sas version to latest * set tags account location to central canada * re-recording queue * changefeed paths generator * mark tests for vid as playback only * fix changefeed * fix pylint make the test account location for tags to central canada * add a delay before calling find_blobs_by_tags * remove tags header * mark a large file test playback only * revert "mark a large file test playback only" skip upload large file test address comment * move tag permission and filter_by_tags permission to kwargs
|
/azp run python - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rakshith91
reviewed
Jul 7, 2020
| @@ -2,6 +2,9 @@ | |||
|
|
|||
| ## 12.3.3 (Unreleased) | |||
|
|
|||
| **New features** | |||
|
|
|||
| - Added support for object replication properties for download response and get properties. | |||
There was a problem hiding this comment.
Thanks for catching this! I have an open pr to update all changelog files #12261
rakshith91
reviewed
Jul 7, 2020
| - Support for ChangeFeedClient: get change feed events by page, get all change feed events, get events in a time range | ||
|
|
||
| This package's | ||
| [documentation](https://github.com/Azure/azure-sdk-for-python/tree/master/sdk/storage/azure-storage-blob-changefeed/README.md) |
There was a problem hiding this comment.
do we want to redirect to the documentation instead of read me here?
There was a problem hiding this comment.
I will address this in the changelog pr
rakshith91
approved these changes
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.