azure-keyvault-administration scaffold #12098
Conversation
chlowell
added
KeyVault
Client
chlowell
force-pushed
the
administration
branch
2 times, most recently
from
cff5d5d
to
299279f
Compare
| self._client = client | ||
| return | ||
|
|
||
| api_version = kwargs.pop("api_version", None) |
There was a problem hiding this comment.
Since this package is currently just 7.2-preview, should we not include checking api_version as a kwarg and calling load_generated_api from the multi_api file?
My thinking is that for now we just only load the 7.2-preview code, and by the time there is a new service api version for administration, we can generate the code with the flag --multiapi and autorest will generate a multiapi client for us, and then we can pass in api_version directly to the generated multiapi client
|
|
||
| # generated clients don't use their credentials parameter | ||
| self._client = generated.client_cls(credentials="", pipeline=pipeline) | ||
| self._models = generated.models |
There was a problem hiding this comment.
same here: I think we can just import v7.2-preview models for now
| # Copyright (c) Microsoft Corporation. | ||
| # Licensed under the MIT License. | ||
| # ------------------------------------ | ||
| from collections import namedtuple |
There was a problem hiding this comment.
If you decide to remove the multi api code from the client base, we can get rid of this file too
chlowell
force-pushed
the
administration
branch
from
299279f
to
a848ef9
Compare
|
Updated with a generated multiapi client (thanks @iscai-msft). |
…into return_none_for_offset_length_v3 * 'master' of https://github.com/Azure/azure-sdk-for-python: [text analytics] add string-index-type support (Azure#13378) [text analytics] fix error response if pii entities is called from v3.0 client (Azure#13383) Send spec (Azure#13143) Anomaly Detector 3.0.0b2 release (Azure#13351) azure-keyvault-administration generated code (Azure#12098) fixed bug in querying by page using continuation token (Azure#13298)
This package will handle Key Vault's RBAC and full vault backup/restore features. This PR adds packaging boilerplate, generated code for the new features, and common
azure-keyvault-*code.