Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tracing README sample #10386

Merged
merged 1 commit into from
Mar 19, 2020
Merged

Update tracing README sample #10386

merged 1 commit into from
Mar 19, 2020

Conversation

rakshith91
Copy link
Contributor

Up and running...otput as expected

Calling start() on a started span.
Calling start() on a started span.
Span(name="/mycontainer", context=SpanContext(trace_id=0x0e8fc47c6ba12003e2a5cdd08bbe9e49, span_id=0x6c43454898522146, trace_state={}), kind=SpanKind.CLIENT, parent=Span(name="BlobServiceClient.create_container", context=SpanContext(trace_id=0x0e8fc47c6ba12003e2a5cdd08bbe9e49, span_id=0x6fdf46f65f578bfb, trace_state={})), start_time=2020-03-19T21:34:22.012116Z, end_time=2020-03-19T21:34:22.973970Z)Span(name="BlobServiceClient.create_container", context=SpanContext(trace_id=0x0e8fc47c6ba12003e2a5cdd08bbe9e49, span_id=0x6fdf46f65f578bfb, trace_state={}), kind=SpanKind.INTERNAL, parent=Span(name="MyApplication", context=SpanContext(trace_id=0x0e8fc47c6ba12003e2a5cdd08bbe9e49, span_id=0x4b5089facaaba871, trace_state={})), start_time=2020-03-19T21:34:22.007130Z, end_time=2020-03-19T21:34:22.977961Z)Span(name="MyApplication", context=SpanContext(trace_id=0x0e8fc47c6ba12003e2a5cdd08bbe9e49, span_id=0x4b5089facaaba871, trace_state={}), kind=SpanKind.INTERNAL, parent=None, start_time=2020-03-19T21:34:22.007130Z, end_time=2020-03-19T21:34:22.977961Z)(trace)

@adxsdk6
Copy link

adxsdk6 commented Mar 19, 2020

Can one of the admins verify this patch?

rakshith91
rakshith91 commented Mar 19, 2020
View reviewed changes
sdk/core/azure-core-tracing-opentelemetry/README.md
@@ -69,7 +69,7 @@ with tracer.start_as_current_span(name="MyApplication"):
client.create_container('mycontainer') # Call will be traced
```

Azure Exporter can be found in the package `opentelemetry-azure-monitor-exporter`
Azure Exporter can be found in the [package](https://github.com/microsoft/opentelemetry-exporters-python) `opentelemetry-azure-monitor-exporter`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought a hyperlink would be super useful

@lmazuel lmazuel merged commit 4ed6294 into Azure:master Mar 19, 2020
@rakshith91 rakshith91 deleted the trace_sample branch March 19, 2020 22:21
johanste
johanste reviewed Mar 19, 2020
View reviewed changes
sdk/core/azure-core-tracing-opentelemetry/README.md
@@ -69,7 +69,7 @@ with tracer.start_as_current_span(name="MyApplication"):
client.create_container('mycontainer') # Call will be traced
```

Azure Exporter can be found in the package `opentelemetry-azure-monitor-exporter`
Azure Exporter can be found in the [package](https://github.com/microsoft/opentelemetry-exporters-python) `opentelemetry-azure-monitor-exporter`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we link to the package on PyPi? It will in turn link back to source if customers want access to that...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E.g. https://pypi.org/project/opentelemetry-azure-monitor-exporter/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanste johanste johanste left review comments

@lmazuel lmazuel lmazuel approved these changes

@xiangyan99 xiangyan99 Awaiting requested review from xiangyan99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rakshith91 @adxsdk6 @lmazuel @johanste