Versioning tool should handle both _version.py and version.py #10365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveenkuttappan
requested review from
danieljurek,
mitchdenny,
scbedd and
weshaggard
as code owners
|
Can one of the admins verify this patch? |
danieljurek
previously approved these changes
Mar 18, 2020
There was a problem hiding this comment.
Chatting offline with @praveenkuttappan this change is necessary because autorest does not generate _version.py files and there is every reason to be able to support all packages we release. 👍
praveenkuttappan
dismissed stale reviews from scbedd and danieljurek
via
b2ba7ce
danieljurek
approved these changes
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version increment tool fails now if version is maintained in version.py. Tool is currently checking only for _version.py file name and that's causing the issue, PR is to look for "version.py" file as well in addition to _version.py file name.