Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[text analytics] score -> confidence_score rename #10279

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

iscai-msft
Copy link
Contributor

Renamed in CategorizedEntity, LinkedEntityMatch, and PiiEntity

fixes #10133

@adxsdk6
Copy link

adxsdk6 commented Mar 12, 2020

Can one of the admins verify this patch?

@samvaity
Copy link
Member

Unrelated to this changeset, but are we also considering to change score on DetectedLanguage to confidenceScore ?

Copy link
Member

@samvaity samvaity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@iscai-msft
Copy link
Contributor Author

iscai-msft commented Mar 12, 2020

Unrelated to this changeset, but are we also considering to change score on DetectedLanguage to confidenceScore ?

@samvaity I don't believe so, I think the service explicitly said not to change DetectedLanguage because there will be upcoming changes to it for the next service version. I don't know what changes they will be though.

Thanks for reviewing!

@iscai-msft iscai-msft merged commit ca2cd35 into Azure:master Mar 13, 2020
@iscai-msft iscai-msft deleted the scores_to_confidence_scores branch March 13, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[text analytics] scores -> confidence_scores
5 participants