Update Version of opentelemetry #10046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
rakshith91
requested review from
bryevdv,
johanste,
lmazuel and
xiangyan99
as code owners
xiangyan99
reviewed
Mar 3, 2020
xiangyan99
reviewed
Mar 3, 2020
lmazuel
reviewed
Mar 4, 2020
lmazuel
reviewed
Mar 4, 2020
sdk/core/azure-core-tracing-opentelemetry/tests/test_tracing_implementations.py
Outdated
Show resolved
Hide resolved
lmazuel
reviewed
Mar 6, 2020
| @@ -2,7 +2,7 @@ | |||
| # Copyright (c) Microsoft Corporation. | |||
| # Licensed under the MIT License. | |||
| # ------------------------------------ | |||
| from ._abstract_span import AbstractSpan, SpanKind, HttpSpanMixin | |||
| from azure.core.tracing._abstract_span import AbstractSpan, SpanKind, HttpSpanMixin | |||
There was a problem hiding this comment.
Please import from azure.core.tracing instead (they are all available there, without the need to import a private module)
There was a problem hiding this comment.
this init is in the azure.core.tracing.
There was a problem hiding this comment.
Laurent meant not to import from "_abstract_span"
There was a problem hiding this comment.
yes, but this import is to expose them publicly from the private module.
rakshith91
force-pushed
the
open_telemetry_for_storage
branch
from
f2362ea to
c2cbd6b
Compare
lmazuel
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.